Skip to content

Commit 54ccb16

Browse files
committed
Add warning in preferences dialog
Add a warning about flickering effects caused by the Edge browser under Preferences > General > Appearance.
1 parent 69f6e45 commit 54ccb16

File tree

3 files changed

+5
-1
lines changed

3 files changed

+5
-1
lines changed

bundles/org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/internal/WorkbenchMessages.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,8 @@ public class WorkbenchMessages extends NLS {
7676

7777
public static String StatusUtil_errorOccurred;
7878

79+
public static String EdgeBrowserDisclaimer;
80+
7981
// ==============================================================================
8082
// Workbench Actions
8183
// ==============================================================================

bundles/org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/internal/dialogs/ViewsPreferencePage.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -214,7 +214,8 @@ private void createHiDPISettingsGroup(Composite parent) {
214214
GridLayout layout = new GridLayout(1, false);
215215
group.setLayout(layout);
216216
Label infoLabel = new Label(group, SWT.WRAP);
217-
infoLabel.setText(WorkbenchMessages.RescaleAtRuntimeDisclaimer);
217+
infoLabel.setText(WorkbenchMessages.RescaleAtRuntimeDisclaimer + System.lineSeparator() + System.lineSeparator()
218+
+ WorkbenchMessages.EdgeBrowserDisclaimer);
218219
infoLabel.setLayoutData(GridDataFactory.defaultsFor(infoLabel).create());
219220
createLabel(group, ""); //$NON-NLS-1$
220221

bundles/org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/internal/messages.properties

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -505,6 +505,7 @@ RescaleAtRuntimeSettingChangeWarningText = Restart for the DPI setting changes t
505505
HiDpiSettingsGroupTitle = HiDPI settings
506506
RescaleAtRuntimeEnabled = Monitor-specific UI &scaling
507507
RescaleAtRuntimeDisclaimer = EXPERIMENTAL! Activating this option will dynamically scale all windows according to the monitor they are currently in. It will also set the default browser to Edge in order to provide the appropriate scaling of content displayed in a browser. This feature is still in development and therefore considered experimental.
508+
EdgeBrowserDisclaimer = WARNING! Changing the size of the browser window can currently cause flickering effects, which are currently being resolved. People who are sensitive to this should therefore either not use Edge at the moment or possibly avoid resizing browser windows.
508509
# --- Workbench -----
509510
WorkbenchPreference_openMode=Open mode
510511
WorkbenchPreference_doubleClick=D&ouble click

0 commit comments

Comments
 (0)