Skip to content

Commit 5aee5c5

Browse files
committed
Find/replace dialog: properly update search string #2322
The find/replace dialog does currently not properly update its search string. When changing the search string and pressing return to execute a search, the previous search string is taken. The reason is an existing workaround for event handling of Combos in GTK. This change ensures that the search and replace input strings are properly updated upon every text modification in the according widgets. Fixes #2322
1 parent 62abff0 commit 5aee5c5

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

bundles/org.eclipse.ui.workbench.texteditor/src/org/eclipse/ui/texteditor/FindReplaceDialog.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -139,12 +139,12 @@ private void ignoreNextEvent() {
139139

140140
@Override
141141
public void modifyText(ModifyEvent e) {
142+
modificationHandler.run();
142143
// XXX: Workaround for Combo bug on Linux (see bug 404202 and bug 410603)
143144
if (fIgnoreNextEvent) {
144145
fIgnoreNextEvent = false;
145146
return;
146147
}
147-
modificationHandler.run();
148148
evaluateFindReplaceStatus();
149149

150150
updateButtonState(!findReplaceLogic.isActive(SearchOptions.INCREMENTAL));

0 commit comments

Comments
 (0)