Improve performance for large selection

Bananeweizen · Bananeweizen · commit 5fb1fb4d790c · 2024-09-18T20:19:20.000+02:00
In a custom RCP application I noticed that selecting a huge amount of
files (by holding Shift-Scroll down for some seconds) gets slower with
the growing size of the selection.

We should short-circuit the evaluation the moment the overall result is
known to be false.
diff --git a/bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/internal/navigator/actions/CommonActionProviderDescriptor.java b/bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/internal/navigator/actions/CommonActionProviderDescriptor.java
@@ -236,6 +236,7 @@ public boolean isEnabledFor(IStructuredSelection aStructuredSelection) {
 				context.setAllowPluginActivation(true);
 				if (NavigatorPlugin.safeEvaluate(enablement, context) != EvaluationResult.TRUE) {
 					isEnabled = false;
+					break;
 				}
 			}
 			if (!isEnabled) {

Original file line number	Diff line number	Diff line change
`@@ -236,6 +236,7 @@ public boolean isEnabledFor(IStructuredSelection aStructuredSelection) {`
`236`	`236`	`context.setAllowPluginActivation(true);`
`237`	`237`	`if (NavigatorPlugin.safeEvaluate(enablement, context) != EvaluationResult.TRUE) {`
`238`	`238`	`isEnabled = false;`
	`239`	`+ break;`
`239`	`240`	`}`
`240`	`241`	`}`
`241`	`242`	`if (!isEnabled) {`