Skip to content

Commit 64500cd

Browse files
committed
Try to stabilize flacky PartRenderingEngineTest
Due to an oversight, the REMOVE_ON_HIDE tag is set on "partB" twice, as opposed to "partB" and "partC". This may occasionally keep the part stack rendered, because "partC" is not removed from the model when hidden. Closes #751
1 parent 51c4ffc commit 64500cd

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

tests/org.eclipse.e4.ui.tests/src/org/eclipse/e4/ui/tests/workbench/PartRenderingEngineTests.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*******************************************************************************
2-
* Copyright (c) 2009, 2023 IBM Corporation and others.
2+
* Copyright (c) 2009, 2025 IBM Corporation and others.
33
*
44
* This program and the accompanying materials
55
* are made available under the terms of the Eclipse Public License 2.0
@@ -2445,7 +2445,7 @@ public void ensureCleanUpAddonCleansUp() {
24452445
partStackForPartBPartC.setSelectedElement(partB);
24462446

24472447
MPart partC = ems.createModelElement(MPart.class);
2448-
partB.getTags().add(EPartService.REMOVE_ON_HIDE_TAG);
2448+
partC.getTags().add(EPartService.REMOVE_ON_HIDE_TAG);
24492449
partStackForPartBPartC.getChildren().add(partC);
24502450
partStackForPartBPartC.setSelectedElement(partC);
24512451

0 commit comments

Comments
 (0)