Perform clean code of bundles/org.eclipse.ui.genericeditor

Author: eclipse-platform-bot

bundles/org.eclipse.ui.genericeditor/src/org/eclipse/ui/internal/genericeditor/AnnotationHoverDelegate.java

@@ -42,16 +42,19 @@ protected boolean isIncluded(Annotation annotation) {
 						return false;
 					}
 					AnnotationPreference preference= EditorsUI.getAnnotationPreferenceLookup().getAnnotationPreference(annotation);
-					if (preference == null)
+					if (preference == null) {
 						return false;
+					}
 					String key= preference.getTextPreferenceKey();
 					if (key != null) {
-						if (!EditorsUI.getPreferenceStore().getBoolean(key))
+						if (!EditorsUI.getPreferenceStore().getBoolean(key)) {
 							return false;
+						}
 					} else {
 						key= preference.getHighlightPreferenceKey();
-						if (key == null || !EditorsUI.getPreferenceStore().getBoolean(key))
+						if (key == null || !EditorsUI.getPreferenceStore().getBoolean(key)) {
 							return false;
+						}
 					}
 					return true;
 				}

bundles/org.eclipse.ui.genericeditor/src/org/eclipse/ui/internal/genericeditor/AutoEditStrategyRegistry.java

@@ -40,7 +40,7 @@ public class AutoEditStrategyRegistry {
 
 	private static final String EXTENSION_POINT_ID = GenericEditorPlugin.BUNDLE_ID + ".autoEditStrategies"; //$NON-NLS-1$
 
-	private Map<IConfigurationElement, GenericContentTypeRelatedExtension<IAutoEditStrategy>> extensions = new LinkedHashMap<>();
+	private final Map<IConfigurationElement, GenericContentTypeRelatedExtension<IAutoEditStrategy>> extensions = new LinkedHashMap<>();
 	private boolean outOfSync = true;
 
 	/**

bundles/org.eclipse.ui.genericeditor/src/org/eclipse/ui/internal/genericeditor/CharacterPairMatcherRegistry.java

@@ -37,7 +37,7 @@ public class CharacterPairMatcherRegistry {
 
 	private static final String EXTENSION_POINT_ID = GenericEditorPlugin.BUNDLE_ID + ".characterPairMatchers"; //$NON-NLS-1$
 
-	private Map<IConfigurationElement, GenericContentTypeRelatedExtension<ICharacterPairMatcher>> extensions = new HashMap<>();
+	private final Map<IConfigurationElement, GenericContentTypeRelatedExtension<ICharacterPairMatcher>> extensions = new HashMap<>();
 	private boolean outOfSync = true;
 
 	/**

bundles/org.eclipse.ui.genericeditor/src/org/eclipse/ui/internal/genericeditor/CompositeContentAssistProcessor.java

@@ -33,11 +33,11 @@
  */
 public class CompositeContentAssistProcessor implements IContentAssistProcessorExtension, IContentAssistProcessor {
 
-	private List<IContentAssistProcessor> fContentAssistProcessors;
+	private final List<IContentAssistProcessor> fContentAssistProcessors;
 
 	/**
 	 * Constructor
-	 * 
+	 *
 	 * @param contentAssistProcessors the children that will actually populate the
 	 *                                output of this content assist processor.
 	 */

bundles/org.eclipse.ui.genericeditor/src/org/eclipse/ui/internal/genericeditor/CompositeQuickAssistProcessor.java

@@ -31,7 +31,7 @@
  */
 public class CompositeQuickAssistProcessor implements IQuickAssistProcessor {
 
-	private List<IQuickAssistProcessor> fProcessors;
+	private final List<IQuickAssistProcessor> fProcessors;
 
 	public CompositeQuickAssistProcessor(List<IQuickAssistProcessor> processors) {
 		this.fProcessors = processors;

bundles/org.eclipse.ui.genericeditor/src/org/eclipse/ui/internal/genericeditor/CompositeReconciler.java

@@ -25,7 +25,7 @@
 import org.eclipse.jface.text.reconciler.IReconcilingStrategy;
 
 public class CompositeReconciler implements IReconciler, IReconcilerExtension {
-	private List<IReconciler> fReconcilers;
+	private final List<IReconciler> fReconcilers;
 
 	public CompositeReconciler(List<IReconciler> reconcilers) {
 		fReconcilers = reconcilers.stream().filter(Objects::nonNull).collect(Collectors.toList());

bundles/org.eclipse.ui.genericeditor/src/org/eclipse/ui/internal/genericeditor/CompositeReconcilerStrategy.java

@@ -26,7 +26,7 @@
 
 public class CompositeReconcilerStrategy
 		implements IReconcilingStrategy, IReconcilingStrategyExtension, ITextViewerLifecycle {
-	private List<IReconcilingStrategy> fReconcilingStrategies;
+	private final List<IReconcilingStrategy> fReconcilingStrategies;
 
 	public CompositeReconcilerStrategy(List<IReconcilingStrategy> strategies) {
 		this.fReconcilingStrategies = strategies;

bundles/org.eclipse.ui.genericeditor/src/org/eclipse/ui/internal/genericeditor/ContentAssistProcessorRegistry.java

@@ -49,7 +49,7 @@ public class ContentAssistProcessorRegistry {
 
 	static class ContentAssistProcessorDelegate implements IContentAssistProcessor {
 		private final IContentAssistProcessor delegate;
-		private IContentType targetContentType;
+		private final IContentType targetContentType;
 
 		public ContentAssistProcessorDelegate(IContentAssistProcessor delegate, IContentType targetContentType) {
 			this.delegate = delegate;
@@ -128,7 +128,7 @@ public IContextInformationValidator getContextInformationValidator() {
 		}
 	}
 
-	private Map<IConfigurationElement, GenericContentTypeRelatedExtension<IContentAssistProcessor>> extensions = new LinkedHashMap<>();
+	private final Map<IConfigurationElement, GenericContentTypeRelatedExtension<IContentAssistProcessor>> extensions = new LinkedHashMap<>();
 	private boolean outOfSync = true;
 
 	/**

bundles/org.eclipse.ui.genericeditor/src/org/eclipse/ui/internal/genericeditor/ContentTypeRelatedExtensionTracker.java

@@ -34,11 +34,11 @@
  */
 final class ContentTypeRelatedExtensionTracker<T> implements ServiceTrackerCustomizer<T, LazyServiceSupplier<T>> {
 
-	private BundleContext bundleContext;
-	private ServiceTracker<T, LazyServiceSupplier<T>> serviceTracker;
+	private final BundleContext bundleContext;
+	private final ServiceTracker<T, LazyServiceSupplier<T>> serviceTracker;
 	private Consumer<LazyServiceSupplier<T>> addAction;
 	private Consumer<LazyServiceSupplier<T>> removeAction;
-	private Display display;
+	private final Display display;
 
 	ContentTypeRelatedExtensionTracker(BundleContext bundleContext, Class<T> serviceType, Display display) {
 		this.bundleContext = bundleContext;
@@ -89,8 +89,8 @@ public Collection<LazyServiceSupplier<T>> getTracked() {
 	}
 
 	public static final class LazyServiceSupplier<S> implements Supplier<S> {
-		private ServiceReference<S> reference;
-		private BundleContext bundleContext;
+		private final ServiceReference<S> reference;
+		private final BundleContext bundleContext;
 		private boolean disposed;
 		private S serviceObject;
 		private IContentType contentType;

bundles/org.eclipse.ui.genericeditor/src/org/eclipse/ui/internal/genericeditor/DefaultWordHighlightReconciler.java

@@ -19,7 +19,7 @@
 
 public class DefaultWordHighlightReconciler extends Reconciler {
 
-	private DefaultWordHighlightStrategy fStrategy;
+	private final DefaultWordHighlightStrategy fStrategy;
 
 	public DefaultWordHighlightReconciler() {
 		fStrategy = new DefaultWordHighlightStrategy();