Skip to content

Commit 6a5ee8d

Browse files
reedenbBeckerWdf
authored andcommitted
Help not shown in "Import preferences" dialog #2759
- Add preferences import and export help contexts to IWorkbenchHelpContextIds.java - Register missing help contexts for WizardPreferencesExportPage1.java and WizardPreferencesImportPage1.java to the help system. Fixes #2759
1 parent 5039550 commit 6a5ee8d

File tree

3 files changed

+21
-0
lines changed

3 files changed

+21
-0
lines changed

bundles/org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/internal/IWorkbenchHelpContextIds.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -249,5 +249,10 @@ public interface IWorkbenchHelpContextIds {
249249
String WORKING_SET_EDIT_WIZARD = PREFIX + "working_set_edit_wizard_context"; //$NON-NLS-1$
250250

251251
String CAPABILITY_PREFERENCE_PAGE = PREFIX + "capabilities_preference_page_context"; //$NON-NLS-1$
252+
252253
String TOGGLE_COOLBAR_ACTION = PREFIX + "toggle_coolbar_action"; //$NON-NLS-1$
254+
255+
String PREFERENCES_IMPORT_WIZARD_PAGE = PREFIX + "preferences_import_wizard_page"; //$NON-NLS-1$
256+
257+
String PREFERENCES_EXPORT_WIZARD_PAGE = PREFIX + "preferences_export_wizard_page"; //$NON-NLS-1$
253258
}

bundles/org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/internal/wizards/preferences/WizardPreferencesExportPage1.java

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,8 @@
2525
import org.eclipse.swt.SWT;
2626
import org.eclipse.swt.widgets.Composite;
2727
import org.eclipse.swt.widgets.Shell;
28+
import org.eclipse.ui.PlatformUI;
29+
import org.eclipse.ui.internal.IWorkbenchHelpContextIds;
2830
import org.eclipse.ui.internal.WorkbenchPlugin;
2931
import org.eclipse.ui.internal.preferences.PreferenceTransferElement;
3032

@@ -54,6 +56,12 @@ public WizardPreferencesExportPage1() {
5456
this(PREFERENCESEXPORTPAGE1);
5557
}
5658

59+
@Override
60+
public void createControl(Composite composite) {
61+
super.createControl(composite);
62+
PlatformUI.setHelp(composite, IWorkbenchHelpContextIds.PREFERENCES_IMPORT_WIZARD_PAGE);
63+
}
64+
5765
protected String getOutputSuffix() {
5866
return ".epf"; //$NON-NLS-1$
5967
}

bundles/org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/internal/wizards/preferences/WizardPreferencesImportPage1.java

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,8 @@
2525
import org.eclipse.swt.SWT;
2626
import org.eclipse.swt.widgets.Composite;
2727
import org.eclipse.swt.widgets.Event;
28+
import org.eclipse.ui.PlatformUI;
29+
import org.eclipse.ui.internal.IWorkbenchHelpContextIds;
2830
import org.eclipse.ui.internal.WorkbenchPlugin;
2931
import org.eclipse.ui.internal.preferences.PreferenceTransferElement;
3032

@@ -52,6 +54,12 @@ public WizardPreferencesImportPage1() {
5254
this("preferencesImportPage1");//$NON-NLS-1$
5355
}
5456

57+
@Override
58+
public void createControl(Composite composite) {
59+
super.createControl(composite);
60+
PlatformUI.setHelp(composite, IWorkbenchHelpContextIds.PREFERENCES_IMPORT_WIZARD_PAGE);
61+
}
62+
5563
@Override
5664
protected String getAllButtonText() {
5765
return PreferencesMessages.WizardPreferencesImportPage1_all;

0 commit comments

Comments
 (0)