Skip to content

Commit 6c459cc

Browse files
EcljpseB0Tjukzi
authored andcommitted
PropertyPageNode: log full exception if any instead of popup only
This issue did not show the root exception: eclipse-jdt/eclipse.jdt.debug#570
1 parent 55329ed commit 6c459cc

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

bundles/org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/internal/dialogs/PropertyPageNode.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
*******************************************************************************/
1414
package org.eclipse.ui.internal.dialogs;
1515

16+
import java.util.List;
1617
import org.eclipse.core.runtime.CoreException;
1718
import org.eclipse.core.runtime.IStatus;
1819
import org.eclipse.jface.preference.IPreferencePage;
@@ -58,8 +59,9 @@ public void createPage() {
5859
} catch (CoreException e) {
5960
// Just inform the user about the error. The details are
6061
// written to the log by now.
61-
IStatus errStatus = StatusUtil.newStatus(e.getStatus(), WorkbenchMessages.PropertyPageNode_errorMessage);
62-
StatusManager.getManager().handle(errStatus, StatusManager.SHOW);
62+
IStatus errStatus = StatusUtil.newStatus(List.of(e.getStatus()),
63+
WorkbenchMessages.PropertyPageNode_errorMessage, null);
64+
StatusManager.getManager().handle(errStatus, StatusManager.SHOW | StatusManager.LOG);
6365
page = new EmptyPropertyPage();
6466
}
6567
setPage(page);

0 commit comments

Comments
 (0)