Skip to content

Commit 6db4ad4

Browse files
mvm-sapBeckerWdf
mvm-sap
authored and
BeckerWdf
committed
[Dark Theme] Fix for highlight issue in sub-tabs
Selected sub-tabs in editor and views were missing blue highlight with the dark theme changes. This has been fixed with this change.
1 parent 8fd556c commit 6db4ad4

File tree

4 files changed

+50
-40
lines changed

4 files changed

+50
-40
lines changed

‎bundles/org.eclipse.ui.themes/css/dark/e4-dark_tabstyle.css‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,12 +40,11 @@ CTabFolder {
4040
CTabFolder[style~='SWT.DOWN'][style~='SWT.BOTTOM'] {
4141
/* Set the styles for the bottom inner tabs (Bug 430051): */
4242
swt-tab-renderer: url('bundleclass://org.eclipse.e4.ui.workbench.renderers.swt/org.eclipse.e4.ui.workbench.renderers.swt.CTabRendering');
43-
swt-unselected-hot-tab-color-background: #161616; /* Bug 465711 */
43+
swt-unselected-hot-tab-color-background: #161616;/* Bug 465711 */
4444
swt-selected-tab-highlight: #316c9b;
4545
swt-selected-highlight-top: false;
4646
}
4747

48-
4948
CTabFolder.active {
5049
swt-selected-tab-highlight: #316c9b;
5150
swt-selected-highlight-top: false;

‎bundles/org.eclipse.ui.themes/css/e4-dark_linux.css‎

Lines changed: 16 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -80,14 +80,28 @@ ImageBasedFrame,
8080
swt-selected-highlight-top: false;
8181
}
8282

83+
.MPartStack CTabFolder[style~='SWT.DOWN'][style~='SWT.BOTTOM'] {
84+
/* Set the styles for the bottom inner tabs (Bug 430051): */
85+
swt-tab-renderer: url('bundleclass://org.eclipse.e4.ui.workbench.renderers.swt/org.eclipse.e4.ui.workbench.renderers.swt.CTabRendering');
86+
swt-unselected-hot-tab-color-background: #161616;/* Bug 465711 */
87+
swt-selected-tab-highlight: #a6a6a6;
88+
swt-selected-highlight-top: true;
89+
}
90+
.MPartStack.active CTabFolder[style~='SWT.DOWN'][style~='SWT.BOTTOM'] {
91+
/* Set the styles for the bottom inner tabs (Bug 430051): */
92+
swt-tab-renderer: url('bundleclass://org.eclipse.e4.ui.workbench.renderers.swt/org.eclipse.e4.ui.workbench.renderers.swt.CTabRendering');
93+
swt-unselected-hot-tab-color-background: #161616;/* Bug 465711 */
94+
swt-selected-tab-highlight: #2b97d7;
95+
swt-selected-highlight-top: true;
96+
}
97+
8398
/*text color of selected tab in editor */
8499
#org-eclipse-ui-editorss CTabItem:selected{
85100
color: '#FFFFFF';
86101
}
87102

88103
#org-eclipse-ui-editorss CTabFolder{
89104
swt-selected-tab-fill : '#1E1F22';
90-
swt-selected-tab-highlight: '#a6a6a6';
91105
swt-selected-highlight-top: true;
92106
swt-draw-custom-tab-content-background: true;
93107
swt-unselected-hot-tab-color-background:#161616;
@@ -98,19 +112,9 @@ swt-selected-tab-highlight: '#a6a6a6';
98112
swt-selected-highlight-top: true;
99113
}
100114

101-
CTabFolder[style~='SWT.DOWN'][style~='SWT.BOTTOM'] {
102-
/* Set the styles for the bottom inner tabs (Bug 430051): */
103-
swt-tab-renderer: url('bundleclass://org.eclipse.e4.ui.workbench.renderers.swt/org.eclipse.e4.ui.workbench.renderers.swt.CTabRendering');
104-
swt-selected-tab-fill: #1E1F22;
105-
swt-unselected-tabs-color: #48484c;
106-
swt-unselected-hot-tab-color-background: #2f2f2f;
107-
swt-selected-tab-highlight: #2b79d7;
108-
swt-selected-highlight-top: false;
109-
}
110-
111115
.Editor Form Composite,
112116
.Editor Form Composite Tree,
113117
.MPartStack.active .Editor Form Composite Tree
114118
{
115119
background-color: #1E1F22;
116-
}
120+
}

‎bundles/org.eclipse.ui.themes/css/e4-dark_mac.css‎

Lines changed: 16 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -66,14 +66,28 @@ Button {
6666
swt-selected-highlight-top: false;
6767
}
6868

69+
.MPartStack CTabFolder[style~='SWT.DOWN'][style~='SWT.BOTTOM'] {
70+
/* Set the styles for the bottom inner tabs (Bug 430051): */
71+
swt-tab-renderer: url('bundleclass://org.eclipse.e4.ui.workbench.renderers.swt/org.eclipse.e4.ui.workbench.renderers.swt.CTabRendering');
72+
swt-unselected-hot-tab-color-background: #161616;/* Bug 465711 */
73+
swt-selected-tab-highlight: #a6a6a6;
74+
swt-selected-highlight-top: true;
75+
}
76+
.MPartStack.active CTabFolder[style~='SWT.DOWN'][style~='SWT.BOTTOM'] {
77+
/* Set the styles for the bottom inner tabs (Bug 430051): */
78+
swt-tab-renderer: url('bundleclass://org.eclipse.e4.ui.workbench.renderers.swt/org.eclipse.e4.ui.workbench.renderers.swt.CTabRendering');
79+
swt-unselected-hot-tab-color-background: #161616;/* Bug 465711 */
80+
swt-selected-tab-highlight: #2b97d7;
81+
swt-selected-highlight-top: true;
82+
}
83+
6984
/*text color of selected tab in editor */
7085
#org-eclipse-ui-editorss CTabItem:selected{
7186
color: '#FFFFFF';
7287
}
7388

7489
#org-eclipse-ui-editorss CTabFolder{
7590
swt-selected-tab-fill : '#1E1F22';
76-
swt-selected-tab-highlight: '#a6a6a6';
7791
swt-selected-highlight-top: true;
7892
swt-draw-custom-tab-content-background: true;
7993
swt-unselected-hot-tab-color-background:#161616;
@@ -84,20 +98,9 @@ Button {
8498
swt-selected-highlight-top: true;
8599
}
86100

87-
CTabFolder[style~='SWT.DOWN'][style~='SWT.BOTTOM'] {
88-
/* Set the styles for the bottom inner tabs (Bug 430051): */
89-
swt-tab-renderer: url('bundleclass://org.eclipse.e4.ui.workbench.renderers.swt/org.eclipse.e4.ui.workbench.renderers.swt.CTabRendering');
90-
swt-selected-tab-fill: #1E1F22;
91-
swt-unselected-tabs-color: #48484c;
92-
swt-unselected-hot-tab-color-background: #2f2f2f;
93-
swt-selected-tab-highlight: #2b79d7;
94-
swt-selected-highlight-top: false;
95-
}
96-
97101
.Editor Form Composite,
98102
.Editor Form Composite Tree,
99103
.MPartStack.active .Editor Form Composite Tree
100104
{
101105
background-color: #1E1F22;
102-
}
103-
106+
}

‎bundles/org.eclipse.ui.themes/css/e4-dark_win.css‎

Lines changed: 17 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -148,33 +148,37 @@ ImageBasedFrame,
148148
swt-selected-highlight-top: false;
149149
}
150150

151+
.MPartStack CTabFolder[style~='SWT.DOWN'][style~='SWT.BOTTOM'] {
152+
/* Set the styles for the bottom inner tabs (Bug 430051): */
153+
swt-tab-renderer: url('bundleclass://org.eclipse.e4.ui.workbench.renderers.swt/org.eclipse.e4.ui.workbench.renderers.swt.CTabRendering');
154+
swt-unselected-hot-tab-color-background: #161616;/* Bug 465711 */
155+
swt-selected-tab-highlight: #a6a6a6;
156+
swt-selected-highlight-top: true;
157+
}
158+
.MPartStack.active CTabFolder[style~='SWT.DOWN'][style~='SWT.BOTTOM'] {
159+
/* Set the styles for the bottom inner tabs (Bug 430051): */
160+
swt-tab-renderer: url('bundleclass://org.eclipse.e4.ui.workbench.renderers.swt/org.eclipse.e4.ui.workbench.renderers.swt.CTabRendering');
161+
swt-unselected-hot-tab-color-background: #161616;/* Bug 465711 */
162+
swt-selected-tab-highlight: #2b97d7;
163+
swt-selected-highlight-top: true;
164+
}
165+
151166
/*text color of selected tab in editor */
152167
#org-eclipse-ui-editorss CTabItem:selected{
153168
color: '#FFFFFF';
154169
}
155170

156171
#org-eclipse-ui-editorss CTabFolder{
157172
swt-selected-tab-fill : '#1E1F22';
158-
swt-selected-tab-highlight: '#a6a6a6';
159173
swt-selected-highlight-top: true;
160174
swt-draw-custom-tab-content-background: true;
161-
swt-unselected-hot-tab-color-background:#161616;
175+
swt-unselected-hot-tab-color-background:#161616;
162176
}
163177

164178
#org-eclipse-ui-editorss CTabFolder.active {
165179
swt-selected-tab-highlight: '#2b79d7';
166180
swt-selected-highlight-top: true;
167-
}
168-
169-
CTabFolder[style~='SWT.DOWN'][style~='SWT.BOTTOM'] {
170-
/* Set the styles for the bottom inner tabs (Bug 430051): */
171-
swt-tab-renderer: url('bundleclass://org.eclipse.e4.ui.workbench.renderers.swt/org.eclipse.e4.ui.workbench.renderers.swt.CTabRendering');
172-
swt-selected-tab-fill: #1E1F22;
173-
swt-unselected-tabs-color: #48484c;
174-
swt-unselected-hot-tab-color-background: #2f2f2f;
175-
swt-selected-tab-highlight: #2b79d7;
176-
swt-selected-highlight-top: false;
177-
}
181+
}
178182

179183
.Editor Form Composite,
180184
.Editor Form Composite Tree,

0 commit comments

Comments
 (0)