Commit 7559164
committed
Don't run in NPE if application is not available in BindingTable
Before #2859
`org.eclipse.e4.ui.bindings.tests` manage to run without application
instance created/set in the global context, because
`core-test` (and not `ui-test`) was used in
org.eclipse.e4.ui.bindings.tests/test.xml.
Thus `org.eclipse.test.coretestapplication` was used to run bindings
tests, not `org.eclipse.test.uitestapplication`. Later one uses
`org.eclipse.ui.ide.workbench` application by default which runs
`E4Application.createE4Workbench()` and that one will create and set
application via `E4Workbench.getServiceContext().set(MApplication.class,
appModel);`.
For now there is no reason to change this behavior, we can simply allow
application to be null in BindingTable which should not affect its
behavior in a context that has no application defined.
Fixes #28721 parent 9cd93e5 commit 7559164
File tree
1 file changed
+1
-1
lines changed- bundles/org.eclipse.e4.ui.bindings/src/org/eclipse/e4/ui/bindings/internal
1 file changed
+1
-1
lines changedLines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
376 | 376 | | |
377 | 377 | | |
378 | 378 | | |
379 | | - | |
| 379 | + | |
380 | 380 | | |
381 | 381 | | |
382 | 382 | | |
| |||
0 commit comments