Skip to content

Commit 75f86b9

Browse files
committed
Un-deprecate ListSelectionDialog constructor
Deprecation has been done when Builder was added which seems to be a trend in the Java world. Undeprecation is done now as : * it's one of the very few (if there are any others) APIs that "mandate" going through a builder, which makes it inconsistent with rest * documentation hasn't been adjusted accordingly (even the class level javadoc has example using the deprecated constructor) * usages in the SDK hasn't been migrated to the builder approach (for years) thus generating a number of deprecation warnings Deprecation could be added again whenever the previous issues are resolved.
1 parent d6af2f2 commit 75f86b9

File tree

1 file changed

+1
-4
lines changed

1 file changed

+1
-4
lines changed

bundles/org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/dialogs/ListSelectionDialog.java

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*******************************************************************************
2-
* Copyright (c) 2000, 2015 IBM Corporation and others.
2+
* Copyright (c) 2000, 2025 IBM Corporation and others.
33
*
44
* This program and the accompanying materials
55
* are made available under the terms of the Eclipse Public License 2.0
@@ -99,10 +99,7 @@ public class ListSelectionDialog extends SelectionDialog {
9999
* @param labelProvider the label provider for displaying model elements
100100
* @param message the message to be displayed at the top of this dialog,
101101
* or <code>null</code> to display a default message
102-
* @deprecated since 3.123; use {@link #of(Object)} instead:
103-
* {@code ListSelectionDialog.of(input).contentProvider(contentProvider).labelProvider(labelProvider).message(message).create(parentShell)}
104102
*/
105-
@Deprecated
106103
public ListSelectionDialog(Shell parentShell, Object input, IStructuredContentProvider contentProvider,
107104
ILabelProvider labelProvider, String message) {
108105
this(parentShell, input, contentProvider, labelProvider, message, null, null, true, null);

0 commit comments

Comments
 (0)