Fix: Correct layout of sticky lines after breadcrumb

When the Breadcrumb feature is toggled on Windows, the sticky lines control layout was messed up.

Fixes: #1954

Author: Christopher-Hermann

bundles/org.eclipse.ui.editors/src/org/eclipse/ui/internal/texteditor/stickyscroll/StickyScrollingControl.java

@@ -184,6 +184,7 @@ private void createControls() {
 		GridDataFactory.fillDefaults().grab(true, false).indent(0, BOTTOM_SEPARATOR_SPACING).span(2, 1).applyTo(bottomSeparator);
 		bottomSeparator.setEnabled(false);
 
+		stickyLinesCanvas.pack();
 		stickyLinesCanvas.moveAbove(null);
 	}
 
@@ -268,7 +269,6 @@ private void layoutStickyLines() {
 		layoutLineNumbers();
 
 		stickyLinesCanvas.setVisible(true);
-		stickyLinesCanvas.pack();
 		calculateAndSetStickyLinesCanvasBounds();
 	}
 

tests/org.eclipse.ui.editors.tests/src/org/eclipse/ui/internal/texteditor/stickyscroll/StickyScrollingControlTest.java

@@ -17,7 +17,6 @@
 import static org.hamcrest.Matchers.greaterThan;
 import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertFalse;
-import static org.junit.Assert.assertNotEquals;
 
 import java.util.List;
 
@@ -190,7 +189,7 @@ public void testLayoutStickyLinesCanvasOnResize() {
 		assertEquals(0, boundsAfterResize.x);
 		assertEquals(0, boundsAfterResize.y);
 		assertThat(boundsAfterResize.width, greaterThan(0));
-		assertNotEquals(boundsAfterResize.width, boundsBeforeResize.width);
+		assertThat(boundsBeforeResize.width, greaterThan(boundsAfterResize.width));
 		assertEquals(boundsAfterResize.height, boundsBeforeResize.height);
 	}