add and use getFormattedDate()

Author: chrisrueger

bundles/org.eclipse.ui.views.log/src/org/eclipse/ui/internal/views/log/LogSession.java

@@ -16,8 +16,10 @@
 package org.eclipse.ui.internal.views.log;
 
 import java.io.PrintWriter;
-import java.text.ParseException;
-import java.text.SimpleDateFormat;
+import java.time.LocalDateTime;
+import java.time.ZoneId;
+import java.time.format.DateTimeFormatter;
+import java.time.format.DateTimeParseException;
 import java.util.Date;
 
 /**
@@ -31,8 +33,12 @@ public class LogSession extends Group {
 	 * @since 3.5
 	 */
 	public static final String SESSION = "!SESSION"; //$NON-NLS-1$
+	private static final DateTimeFormatter LOCAL_SDF = DateTimeFormatter.ofPattern(LogEntry.F_DATE_FORMAT)
+			.withZone(ZoneId.systemDefault());
+
 	private String sessionData;
 	private Date date;
+	private String fDateString;
 
 	public LogSession() {
 		super(Messages.LogViewLabelProvider_Session);
@@ -42,11 +48,24 @@ public Date getDate() {
 		return date;
 	}
 
+	/**
+	 * Returns a pretty-print formatting for the date for this entry
+	 * 
+	 * @return the formatted date for this entry
+	 */
+	public String getFormattedDate() {
+		if (fDateString == null) {
+			fDateString = LOCAL_SDF.format(getDate().toInstant());
+		}
+		return fDateString;
+	}
+
 	public void setDate(String dateString) {
-		SimpleDateFormat formatter = new SimpleDateFormat("yyyy-MM-dd HH:mm:ss.SSS"); //$NON-NLS-1$
 		try {
-			date = formatter.parse(dateString);
-		} catch (ParseException e) { // do nothing
+			LocalDateTime ldt = LocalDateTime.parse(dateString, LOCAL_SDF);
+			this.date = Date.from(ldt.atZone(ZoneId.systemDefault()).toInstant());
+		} catch (DateTimeParseException e) {
+			// do nothing
 		}
 	}
 

bundles/org.eclipse.ui.views.log/src/org/eclipse/ui/internal/views/log/LogViewLabelProvider.java

@@ -15,8 +15,6 @@
  *******************************************************************************/
 package org.eclipse.ui.internal.views.log;
 
-import java.text.DateFormat;
-import java.text.SimpleDateFormat;
 import java.util.ArrayList;
 import org.eclipse.core.runtime.IStatus;
 import org.eclipse.jface.resource.JFaceResources;
@@ -35,8 +33,6 @@ public class LogViewLabelProvider extends LabelProvider implements ITableLabelPr
 	private Image errorWithStackImage;
 	private Image hierarchicalImage;
 	ArrayList<Object> consumers = new ArrayList<>();
-	private DateFormat dateFormat = new SimpleDateFormat(LogEntry.F_DATE_FORMAT);
-
 	private LogView logView;
 
 	public LogViewLabelProvider(LogView logView) {
@@ -82,7 +78,7 @@ public String getColumnText(Object element, int columnIndex) {
 			if (session.getDate() == null)
 				return ""; //$NON-NLS-1$
 
-			return dateFormat.format(session.getDate());
+			return session.getFormattedDate();
 		}
 
 		if ((element instanceof Group) && (columnIndex == 0)) {
@@ -107,7 +103,7 @@ public String getColumnText(Object element, int columnIndex) {
 					if (entry.getPluginId() != null)
 						return entry.getPluginId();
 				case 2 :
-					return dateFormat.format(entry.getDate());
+					return entry.getFormattedDate();
 			}
 		}