Skip to content

Commit 82b9eff

Browse files
committed
Deprecate IWorkbenchPage#zoomOut() for removal
The method IWorkbenchPage#zoomOut() has never been implemented in the sole interface implementation WorkbenchPage. All existing consumers rely on the #toogleZoom() implementation. This change thus deprecates the method for removal, as it has never been implemented and required and will unlikely ever get implemented. The related functionality of WorkbenchPage#unzoomAllPerspective() is also unused, and since it's internal this change just removes it.
1 parent 23d4b86 commit 82b9eff

File tree

2 files changed

+7
-12
lines changed

2 files changed

+7
-12
lines changed

bundles/org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/IWorkbenchPage.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1051,7 +1051,13 @@ IEditorPart openEditor(final IEditorInput input, final String editorId, final bo
10511051
* does nothing.
10521052
*
10531053
* @since 3.2
1054+
*
1055+
* @deprecated this method has never been implemented; use
1056+
* {@link #toggleZoom(IWorkbenchPartReference)} to toggle between
1057+
* maximized and non-maximized state instead of explicitly zooming
1058+
* out
10541059
*/
1060+
@Deprecated(forRemoval = true, since = "2025-12")
10551061
void zoomOut();
10561062

10571063
/**

bundles/org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/internal/WorkbenchPage.java

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1809,23 +1809,12 @@ private boolean close(boolean save, boolean unsetPage) {
18091809
return true;
18101810
}
18111811

1812-
/**
1813-
* Forces all perspectives on the page to zoom out.
1814-
*/
1815-
public void unzoomAllPerspectives() {
1816-
// TODO compat: we have no min/max behaviour
1817-
}
1818-
18191812
/**
18201813
* Cleanup.
18211814
*/
18221815
public void dispose() {
18231816
legacyWindow = null;
18241817
largeFileLimitsPreferenceHandler.dispose();
1825-
// // Always unzoom
1826-
// if (isZoomed()) {
1827-
// zoomOut();
1828-
// }
18291818
//
18301819
// // makeActiveEditor(null);
18311820
// // makeActive(null);
@@ -4350,7 +4339,7 @@ public void updateActionBars() {
43504339

43514340
@Override
43524341
public void zoomOut() {
4353-
// TODO compat: what does the zoom do?
4342+
// to be removed once interface method is removed
43544343
}
43554344

43564345
@Override

0 commit comments

Comments
 (0)