Stop using assertTrue(false)

This is plain wrong as it will always fail. Use fail directly or
simplify tests where possible to remove the need for it.
Other small improvements to tests done wherever seen while doing the
main changes here.

Author: akurtakov

tests/org.eclipse.jface.text.tests/src/org/eclipse/jface/text/tests/HTML2TextReaderTest.java

@@ -1,5 +1,5 @@
 /*******************************************************************************
- * Copyright (c) 2006, 2016 IBM Corporation and others.
+ * Copyright (c) 2006, 2024 IBM Corporation and others.
  *
  * This program and the accompanying materials
  * are made available under the terms of the Eclipse Public License 2.0
@@ -16,6 +16,7 @@
 
 import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertTrue;
+import static org.junit.Assert.fail;
 
 import java.io.IOException;
 import java.io.Reader;
@@ -76,7 +77,7 @@ private void verify(String input, String expectedOutput, int styleRangeCount) th
 			StyleRange range2= ranges.get(i + 1);
 
 			if (range1.start + range1.length > range2.start) {
-				assertTrue("StyleRanges overlap", false);
+				fail("StyleRanges overlap");
 			}
 		}
 
@@ -108,7 +109,7 @@ private void verify(String input, String expectedOutput, StyleRange[] styleRange
 			StyleRange range2= ranges.get(i + 1);
 
 			if (range1.start + range1.length > range2.start) {
-				assertTrue("StyleRanges overlap", false);
+				fail("StyleRanges overlap");
 			}
 		}
 

tests/org.eclipse.text.tests/src/org/eclipse/text/tests/AnnotationModelExtension2Test.java

@@ -1,5 +1,5 @@
 /*******************************************************************************
- * Copyright (c) 2007, 2015 IBM Corporation and others.
+ * Copyright (c) 2007, 2024 IBM Corporation and others.
  *
  * This program and the accompanying materials
  * are made available under the terms of the Eclipse Public License 2.0
@@ -13,7 +13,7 @@
  *******************************************************************************/
 package org.eclipse.text.tests;
 
-import static org.junit.Assert.assertTrue;
+import static org.junit.Assert.fail;
 
 import java.util.ArrayList;
 import java.util.Arrays;
@@ -139,7 +139,7 @@ private void assertEquals(Annotation[] expected, Annotation[] actual, IAnnotatio
 		for (Annotation a : actual) {
 			if (!expectedSet.contains(a)) {
 				String message = "Unexpected annotation " + getName(a) + " in result with models [" + getAnnotationModelNames(insideModel, beforeModel, afterModel) + "]";
-				assertTrue(message, false);
+				fail(message);
 			}
 			expectedSet.remove(a);
 		}
@@ -149,7 +149,7 @@ private void assertEquals(Annotation[] expected, Annotation[] actual, IAnnotatio
 			for (Annotation missing : expectedSet) {
 				message= message + "\n" + getName(missing);
 			}
-			assertTrue(message, false);
+			fail(message);
 		}
 	}