Hide commands from disabled activities in onboarding

This change adjusts ModeledPageLayout.addEditorOnboardingCommandId() to
not show commands from activities that are not enabled.

Fixes: #3248
Signed-off-by: Simeon Andreev <[email protected]>

Author: trancexpress

bundles/org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/internal/e4/compatibility/ModeledPageLayout.java

@@ -24,6 +24,7 @@
 import java.util.function.Function;
 import java.util.function.Predicate;
 import org.eclipse.core.runtime.IStatus;
+import org.eclipse.e4.core.services.contributions.IContributionFactory;
 import org.eclipse.e4.ui.internal.workbench.PartStackUtil;
 import org.eclipse.e4.ui.model.application.MApplication;
 import org.eclipse.e4.ui.model.application.commands.MBindingTable;
@@ -644,6 +645,10 @@ public void addEditorOnboardingCommandId(String commandId) {
 		if (numberOfOnboardingCommands >= 5)
 			return;
 
+		IContributionFactory contributionFactory = application.getContext().get(IContributionFactory.class);
+		if (!contributionFactory.isEnabled(commandId))
+			return;
+
 		Predicate<MKeyBinding> commandWithEqualId = b -> Optional.of(b).map(MKeyBinding::getCommand)
 				.map(MCommand::getElementId).filter(elementId -> elementId.equals(commandId)).isPresent();