Skip to content

Commit 8abbf53

Browse files
eclipse-platform-botakurtakov
authored andcommitted
Perform clean code of bundles/org.eclipse.urischeme
1 parent e5240ed commit 8abbf53

File tree

8 files changed

+15
-15
lines changed

8 files changed

+15
-15
lines changed

bundles/org.eclipse.urischeme/src/org/eclipse/urischeme/AutoRegisterSchemeHandlersJob.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -38,9 +38,9 @@ public class AutoRegisterSchemeHandlersJob extends Job {
3838
private static final String PROCESSED_SCHEMES_PREFERENCE = "processedSchemes"; //$NON-NLS-1$
3939
private static final String SCHEME_LIST_PREFERENCE_SEPARATOR = ","; //$NON-NLS-1$
4040
private static boolean alreadyTriggered = false;
41-
private IEclipsePreferences testPreferenceNode;
42-
private IUriSchemeExtensionReader testExtensionReader;
43-
private IOperatingSystemRegistration testOsRegistration;
41+
private final IEclipsePreferences testPreferenceNode;
42+
private final IUriSchemeExtensionReader testExtensionReader;
43+
private final IOperatingSystemRegistration testOsRegistration;
4444

4545
public AutoRegisterSchemeHandlersJob() {
4646
// all defaults for lazy init NOT on UI thread

bundles/org.eclipse.urischeme/src/org/eclipse/urischeme/internal/UriSchemeExtensionReader.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -98,8 +98,8 @@ private IUriSchemeHandler createExecutableSchemeHandler(IConfigurationElement el
9898

9999
private static class Scheme implements IScheme {
100100

101-
private String uriScheme;
102-
private String uriSchemeDescription;
101+
private final String uriScheme;
102+
private final String uriSchemeDescription;
103103

104104
public Scheme(String uriScheme, String uriSchemeDescription) {
105105
this.uriScheme = uriScheme;

bundles/org.eclipse.urischeme/src/org/eclipse/urischeme/internal/UriSchemeProcessor.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
*/
2929
public class UriSchemeProcessor implements IUriSchemeProcessor {
3030

31-
private Map<String, IUriSchemeHandler> createdHandlers = new HashMap<>();
31+
private final Map<String, IUriSchemeHandler> createdHandlers = new HashMap<>();
3232
IUriSchemeExtensionReader reader = IUriSchemeExtensionReader.newInstance();
3333

3434
/**

bundles/org.eclipse.urischeme/src/org/eclipse/urischeme/internal/registration/DesktopFileWriter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ public class DesktopFileWriter {
3636
private static final String KEY_MIME_TYPE = "MimeType"; //$NON-NLS-1$
3737
private static final String KEY_EXEC = "Exec"; //$NON-NLS-1$
3838
private static final String EXEC_URI_PLACEHOLDER = " %u"; //$NON-NLS-1$
39-
private Map<String, String> properties;
39+
private final Map<String, String> properties;
4040

4141
/**
4242
* Creates an instance of the DekstopFileWriter. Throws an

bundles/org.eclipse.urischeme/src/org/eclipse/urischeme/internal/registration/PlistFileWriter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@ public void removeScheme(String scheme) {
171171
public interface IOSupplier<T> {
172172
T get() throws IOException;
173173
}
174-
174+
175175
/**
176176
* Writes the content (xml) of the .plist file to the supplied {@link Writer}
177177
*

bundles/org.eclipse.urischeme/src/org/eclipse/urischeme/internal/registration/RegistrationLinux.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,9 +35,9 @@ public class RegistrationLinux implements IOperatingSystemRegistration {
3535

3636
private static final String X_SCHEME_HANDLER_PREFIX = "x-scheme-handler/"; //$NON-NLS-1$
3737

38-
private IFileProvider fileProvider;
39-
private IProcessExecutor processExecutor;
40-
private String productName;
38+
private final IFileProvider fileProvider;
39+
private final IProcessExecutor processExecutor;
40+
private final String productName;
4141

4242
public RegistrationLinux() {
4343
this(new FileProvider(), new ProcessExecutor(), getProductName());

bundles/org.eclipse.urischeme/src/org/eclipse/urischeme/internal/registration/RegistrationMacOsX.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,8 @@ public class RegistrationMacOsX implements IOperatingSystemRegistration {
3232
private static final String TRAILING_HEX_VALUE_WITH_BRACKETS = "\\s\\(0x\\w*\\)"; //$NON-NLS-1$
3333
private static final String PATH_WITH_CAPTURING_GROUP = "path:\\s*(.*)"; //$NON-NLS-1$
3434

35-
private IFileProvider fileProvider;
36-
private IProcessExecutor processExecutor;
35+
private final IFileProvider fileProvider;
36+
private final IProcessExecutor processExecutor;
3737

3838
private String[] lsRegisterOutput = null;
3939

bundles/org.eclipse.urischeme/src/org/eclipse/urischeme/internal/registration/SchemeInformation.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,8 @@
1919
*/
2020
public class SchemeInformation implements ISchemeInformation {
2121

22-
private String name;
23-
private String description;
22+
private final String name;
23+
private final String description;
2424
private boolean handled;
2525
private String handlerInstanceLocation;
2626

0 commit comments

Comments
 (0)