Skip to content

Commit 8ae1e87

Browse files
committed
Mark unused methods for removal in WorkbenchWindowAdvisor
These methods are not used since the 3.x migration, time to mark them for deletion.
1 parent 323f82d commit 8ae1e87

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

bundles/org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/application/WorkbenchWindowAdvisor.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -272,7 +272,7 @@ public void postWindowClose() {
272272
* @deprecated This method is no longer used. Applications now define workbench
273273
* window contents in their application model.
274274
*/
275-
@Deprecated
275+
@Deprecated(forRemoval = true, since = "2025-03")
276276
public void createWindowContents(Shell shell) {
277277
((WorkbenchWindowConfigurer) getWindowConfigurer()).createDefaultContents(shell);
278278
}
@@ -291,7 +291,7 @@ public void createWindowContents(Shell shell) {
291291
* @deprecated This method is no longer used. Applications now define workbench
292292
* window contents in their application model.
293293
*/
294-
@Deprecated
294+
@Deprecated(forRemoval = true, since = "2025-03")
295295
public Control createEmptyWindowContents(Composite parent) {
296296
return null;
297297
}

tests/org.eclipse.ui.tests.rcp/Eclipse RCP Tests/org/eclipse/ui/tests/rcp/WorkbenchWindowConfigurerTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -294,15 +294,15 @@ public IStatus saveState(IMemento memento) {
294294
}};
295295
}
296296

297+
@SuppressWarnings("removal")
297298
@Override
298-
@SuppressWarnings("deprecation")
299299
public Control createEmptyWindowContents(Composite parent) {
300300
ensureThread();
301301
return super.createEmptyWindowContents(parent);
302302
}
303303

304+
@SuppressWarnings("removal")
304305
@Override
305-
@SuppressWarnings("deprecation")
306306
public void createWindowContents(Shell shell) {
307307
ensureThread();
308308
super.createWindowContents(shell);

0 commit comments

Comments
 (0)