Skip to content

Commit 8c2be45

Browse files
feilimblaeubi
authored andcommitted
Code review feedback change #1, change the references to 'dummy' throughout to be replaced with 'e4', including the plugin name itself.
1 parent 87a9d52 commit 8c2be45

File tree

9 files changed

+12
-12
lines changed

9 files changed

+12
-12
lines changed

examples/org.eclipse.e4.ui.examples.dummyeditor/.project renamed to examples/org.eclipse.e4.ui.examples.e4editor/.project

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<projectDescription>
3-
<name>org.eclipse.e4.ui.examples.dummyeditor</name>
3+
<name>org.eclipse.e4.ui.examples.e4editor</name>
44
<comment></comment>
55
<projects>
66
</projects>

examples/org.eclipse.e4.ui.examples.dummyeditor/META-INF/MANIFEST.MF renamed to examples/org.eclipse.e4.ui.examples.e4editor/META-INF/MANIFEST.MF

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
Manifest-Version: 1.0
22
Bundle-ManifestVersion: 2
33
Bundle-Name: DummyEditor
4-
Bundle-SymbolicName: org.eclipse.e4.ui.examples.dummyeditor;singleton:=true
4+
Bundle-SymbolicName: org.eclipse.e4.ui.examples.e4editor;singleton:=true
55
Bundle-Version: 1.0.0.qualifier
66
Require-Bundle: org.eclipse.swt,
77
org.eclipse.jface,

examples/org.eclipse.e4.ui.examples.dummyeditor/fragment.e4xmi renamed to examples/org.eclipse.e4.ui.examples.e4editor/fragment.e4xmi

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,18 @@
11
<?xml version="1.0" encoding="ASCII"?>
22
<fragment:ModelFragments xmi:version="2.0" xmlns:xmi="http://www.omg.org/XMI" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:basic="http://www.eclipse.org/ui/2010/UIModel/application/descriptor/basic" xmlns:commands="http://www.eclipse.org/ui/2010/UIModel/application/commands" xmlns:fragment="http://www.eclipse.org/ui/2010/UIModel/fragment" xmlns:menu="http://www.eclipse.org/ui/2010/UIModel/application/ui/menu" xmi:id="_6pcn8N7gEe-4ibwCH2r47g">
33
<fragments xsi:type="fragment:StringModelFragment" xmi:id="_Bzi3IN7hEe-4ibwCH2r47g" featurename="menuContributions" parentElementId="org.eclipse.e4.legacy.ide.application">
4-
<elements xsi:type="menu:MenuContribution" xmi:id="_JtwUoN7hEe-4ibwCH2r47g" elementId="org.eclipse.e4.ui.examples.dummyeditor.menucontribution.0" positionInParent="after=additions" parentId="window">
5-
<children xsi:type="menu:HandledMenuItem" xmi:id="_XMBQkN7hEe-4ibwCH2r47g" elementId="org.eclipse.e4.ui.examples.dummyeditor.handledmenuitem.opendummyeditor" label="Open Dummy Editor" command="_e-OBkN7hEe-4ibwCH2r47g"/>
4+
<elements xsi:type="menu:MenuContribution" xmi:id="_JtwUoN7hEe-4ibwCH2r47g" elementId="org.eclipse.e4.ui.examples.e4editor.menucontribution.0" positionInParent="after=additions" parentId="window">
5+
<children xsi:type="menu:HandledMenuItem" xmi:id="_XMBQkN7hEe-4ibwCH2r47g" elementId="org.eclipse.e4.ui.examples.e4editor.handledmenuitem.opene4editor" label="Open E4 Editor" command="_e-OBkN7hEe-4ibwCH2r47g"/>
66
</elements>
77
</fragments>
88
<fragments xsi:type="fragment:StringModelFragment" xmi:id="_c1D8sN7hEe-4ibwCH2r47g" featurename="commands" parentElementId="org.eclipse.e4.legacy.ide.application">
9-
<elements xsi:type="commands:Command" xmi:id="_e-OBkN7hEe-4ibwCH2r47g" elementId="org.eclipse.e4.ui.examples.dummyeditor.command.opendummyeditor" commandName="Open Dummy Editor"/>
9+
<elements xsi:type="commands:Command" xmi:id="_e-OBkN7hEe-4ibwCH2r47g" elementId="org.eclipse.e4.ui.examples.e4editor.command.opene4editor" commandName="Open E4 Editor"/>
1010
</fragments>
1111
<fragments xsi:type="fragment:StringModelFragment" xmi:id="__zpxEN7iEe-4ibwCH2r47g" featurename="handlers" parentElementId="org.eclipse.e4.legacy.ide.application">
12-
<elements xsi:type="commands:Handler" xmi:id="_DRaRYN7jEe-4ibwCH2r47g" elementId="org.eclipse.e4.ui.examples.dummyeditor.handler.0" contributionURI="bundleclass://org.eclipse.e4.ui.examples.dummyeditor/org.eclipse.e4.ui.examples.dummyeditor.OpenEditorHandler" command="_e-OBkN7hEe-4ibwCH2r47g"/>
12+
<elements xsi:type="commands:Handler" xmi:id="_DRaRYN7jEe-4ibwCH2r47g" elementId="org.eclipse.e4.ui.examples.e4editor.handler.0" contributionURI="bundleclass://org.eclipse.e4.ui.examples.e4editor/org.eclipse.e4.ui.examples.e4editor.OpenEditorHandler" command="_e-OBkN7hEe-4ibwCH2r47g"/>
1313
</fragments>
1414
<fragments xsi:type="fragment:StringModelFragment" xmi:id="_WJS9YN7jEe-4ibwCH2r47g" featurename="descriptors" parentElementId="org.eclipse.e4.legacy.ide.application">
15-
<elements xsi:type="basic:PartDescriptor" xmi:id="_YIdYwN7jEe-4ibwCH2r47g" elementId="org.eclipse.e4.ui.examples.dummyeditor.partdescriptor.dummyeditor" label="DummyEditor" closeable="true" contributionURI="bundleclass://org.eclipse.e4.ui.examples.dummyeditor/org.eclipse.e4.ui.examples.dummyeditor.DummyEditor">
15+
<elements xsi:type="basic:PartDescriptor" xmi:id="_YIdYwN7jEe-4ibwCH2r47g" elementId="org.eclipse.e4.ui.examples.e4editor.partdescriptor.e4editor" label="E4 Editor" closeable="true" contributionURI="bundleclass://org.eclipse.e4.ui.examples.e4editor/org.eclipse.e4.ui.examples.e4editor.E4Editor">
1616
<tags>Editor</tags>
1717
<tags>removeOnHide</tags>
1818
</elements>
Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,20 +10,20 @@
1010
* Contributors: Feilim Breatnach, Pilz Ireland
1111
*******************************************************************************/
1212

13-
package org.eclipse.e4.ui.examples.dummyeditor;
13+
package org.eclipse.e4.ui.examples.e4editor;
1414

1515
import jakarta.annotation.PostConstruct;
1616

1717
import org.eclipse.swt.SWT;
1818
import org.eclipse.swt.widgets.Composite;
1919
import org.eclipse.swt.widgets.Text;
2020

21-
public class DummyEditor {
21+
public class E4Editor {
2222

2323
@PostConstruct
2424
public void postConstruct(Composite parent) {
2525
Text label = new Text(parent, SWT.ITALIC);
26-
label.setText("Dummy Editor Content...");
26+
label.setText("E4 Editor Content...");
2727

2828
}
2929
}
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
* Contributors: Feilim Breatnach, Pilz Ireland
1111
*******************************************************************************/
1212

13-
package org.eclipse.e4.ui.examples.dummyeditor;
13+
package org.eclipse.e4.ui.examples.e4editor;
1414

1515
import java.util.List;
1616
import java.util.Optional;
@@ -29,7 +29,7 @@
2929

3030
public class OpenEditorHandler {
3131

32-
public static final String DUMMY_EDITOR_DESCRIPTOR_ID = "org.eclipse.e4.ui.examples.dummyeditor.partdescriptor.dummyeditor";
32+
public static final String DUMMY_EDITOR_DESCRIPTOR_ID = "org.eclipse.e4.ui.examples.e4editor.partdescriptor.e4editor";
3333

3434
@Execute
3535
public void execute(EModelService modelService, MApplication application, EPartService partService) {

0 commit comments

Comments
 (0)