Skip to content

Commit 8cfccdc

Browse files
committed
Help not shown in "Import preferences" dialog #2759
- Add preferences import and export help contexts to IWorkbenchHelpContextIds.java - Register missing help contexts for WizardPreferencesExportPage1.java and WizardPreferencesImportPage1.java to the help system. Fixes #2759
1 parent 1042a13 commit 8cfccdc

File tree

3 files changed

+23
-0
lines changed

3 files changed

+23
-0
lines changed

bundles/org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/internal/IWorkbenchHelpContextIds.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -249,5 +249,10 @@ public interface IWorkbenchHelpContextIds {
249249
String WORKING_SET_EDIT_WIZARD = PREFIX + "working_set_edit_wizard_context"; //$NON-NLS-1$
250250

251251
String CAPABILITY_PREFERENCE_PAGE = PREFIX + "capabilities_preference_page_context"; //$NON-NLS-1$
252+
252253
String TOGGLE_COOLBAR_ACTION = PREFIX + "toggle_coolbar_action"; //$NON-NLS-1$
254+
255+
String PREFERENCES_IMPORT_WIZARD_PAGE = PREFIX + "preferences_import_wizard_page"; //$NON-NLS-1$
256+
257+
String PREFERENCES_EXPORT_WIZARD_PAGE = PREFIX + "preferences_export_wizard_page"; //$NON-NLS-1$
253258
}

bundles/org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/internal/wizards/preferences/WizardPreferencesExportPage1.java

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,8 @@
2525
import org.eclipse.swt.SWT;
2626
import org.eclipse.swt.widgets.Composite;
2727
import org.eclipse.swt.widgets.Shell;
28+
import org.eclipse.ui.PlatformUI;
29+
import org.eclipse.ui.internal.IWorkbenchHelpContextIds;
2830
import org.eclipse.ui.internal.WorkbenchPlugin;
2931
import org.eclipse.ui.internal.preferences.PreferenceTransferElement;
3032

@@ -47,6 +49,13 @@ protected WizardPreferencesExportPage1(String name) {
4749
setDescription(PreferencesMessages.WizardPreferencesExportPage1_exportDescription);
4850
}
4951

52+
@Override
53+
public void createControl(Composite composite) {
54+
super.createControl(composite);
55+
PlatformUI.getWorkbench().getHelpSystem().setHelp(getControl(),
56+
IWorkbenchHelpContextIds.PREFERENCES_EXPORT_WIZARD_PAGE);
57+
}
58+
5059
/**
5160
* Create an instance of this class
5261
*/

bundles/org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/internal/wizards/preferences/WizardPreferencesImportPage1.java

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,8 @@
2525
import org.eclipse.swt.SWT;
2626
import org.eclipse.swt.widgets.Composite;
2727
import org.eclipse.swt.widgets.Event;
28+
import org.eclipse.ui.PlatformUI;
29+
import org.eclipse.ui.internal.IWorkbenchHelpContextIds;
2830
import org.eclipse.ui.internal.WorkbenchPlugin;
2931
import org.eclipse.ui.internal.preferences.PreferenceTransferElement;
3032

@@ -45,6 +47,13 @@ protected WizardPreferencesImportPage1(String pageName) {
4547
setDescription(PreferencesMessages.WizardPreferencesImportPage1_importDescription);
4648
}
4749

50+
@Override
51+
public void createControl(Composite composite) {
52+
super.createControl(composite);
53+
PlatformUI.getWorkbench().getHelpSystem().setHelp(getControl(),
54+
IWorkbenchHelpContextIds.PREFERENCES_IMPORT_WIZARD_PAGE);
55+
}
56+
4857
/**
4958
* Create an instance of this class
5059
*/

0 commit comments

Comments
 (0)