Skip to content

Commit 9a7cab8

Browse files
committed
#2323 'Restore Defaults' button uses a different value when USE_MARKER_LIMITS pref is false.
1 parent c603575 commit 9a7cab8

File tree

3 files changed

+8
-2
lines changed

3 files changed

+8
-2
lines changed

bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/IDEInternalPreferences.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -179,4 +179,9 @@ public interface IDEInternalPreferences {
179179
*/
180180
String HELP_CONTEXT_AVAILABILITY_CHECK = "helpContextAvailabilityCheck"; //$NON-NLS-1$
181181

182+
/**
183+
* The default value to use for 'items per group' when using limits in the
184+
* problem view.
185+
*/
186+
int MARKER_LIMITS_VALUE_DEFAULT = 100;
182187
}

bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/IDEPreferenceInitializer.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ public void initializeDefaultPreferences() {
7171
node.putInt(IDEInternalPreferences.PROBLEMS_LIMIT, 100);
7272

7373
node.putBoolean(IDEInternalPreferences.USE_MARKER_LIMITS, true);
74-
node.putInt(IDEInternalPreferences.MARKER_LIMITS_VALUE, 100);
74+
node.putInt(IDEInternalPreferences.MARKER_LIMITS_VALUE, IDEInternalPreferences.MARKER_LIMITS_VALUE_DEFAULT);
7575

7676
node.put(IDEInternalPreferences.IMPORT_FILES_AND_FOLDERS_TYPE, ""); //$NON-NLS-1$
7777
node.putBoolean(IDEInternalPreferences.IMPORT_FILES_AND_FOLDERS_RELATIVE, true);

bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/views/markers/FiltersConfigurationDialog.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -707,7 +707,8 @@ protected void performDefaults() {
707707

708708
IPreferenceStore preferenceStore = IDEWorkbenchPlugin.getDefault().getPreferenceStore();
709709
boolean useMarkerLimits = preferenceStore.getBoolean(IDEInternalPreferences.USE_MARKER_LIMITS);
710-
int markerLimits = useMarkerLimits ? preferenceStore.getInt(IDEInternalPreferences.MARKER_LIMITS_VALUE) : 1000;
710+
int markerLimits = useMarkerLimits ? preferenceStore.getInt(IDEInternalPreferences.MARKER_LIMITS_VALUE)
711+
: IDEInternalPreferences.MARKER_LIMITS_VALUE_DEFAULT;
711712

712713
limitButton.setSelection(useMarkerLimits);
713714
updateLimitTextEnablement();

0 commit comments

Comments
 (0)