Commit 9dc17d7
Fix race condition in ProgressContantsTest.testKeepOneProperty
The test was failing intermittently with "expected:<1> but was:<0>" because
it was asserting the KEEPONE property result before the async cleanup logic
had completed. The previous fix added an error job as a synchronization
marker, but this wasn't sufficient as the cleanup can still be pending after
the error job appears.
This fix adds explicit waits for the actual condition being tested: that
exactly 1 item from the DummyFamilyJob family remains in the progress view.
By waiting for countBelongingProgressItems() to return 1, we ensure the
KEEPONE cleanup has fully stabilized before asserting.
Fixes: https://github.com/eclipse-platform/eclipse.platform.ui/runs/55056915330
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <[email protected]>1 parent 1a43fc1 commit 9dc17d7
File tree
1 file changed
+4
-2
lines changed- tests/org.eclipse.ui.tests/Eclipse UI Tests/org/eclipse/ui/tests/progress
1 file changed
+4
-2
lines changedLines changed: 4 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
223 | 223 | | |
224 | 224 | | |
225 | 225 | | |
| 226 | + | |
| 227 | + | |
226 | 228 | | |
227 | 229 | | |
228 | 230 | | |
| |||
254 | 256 | | |
255 | 257 | | |
256 | 258 | | |
257 | | - | |
258 | | - | |
| 259 | + | |
| 260 | + | |
259 | 261 | | |
260 | 262 | | |
261 | 263 | | |
| |||
0 commit comments