ToolItemUpdater: fix possible Integer overflow

EcljpseB0T · jukzi · commit a0a0ef82969e · 2024-12-06T08:47:42.000+01:00
Both DELAY and 1_000_000 are Integers. Multiplied they could exceed max
integer. Currently the DELAY is small enough to not overflow, but
changing the constant would silently overflow.
diff --git a/bundles/org.eclipse.e4.ui.workbench.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/ToolItemUpdater.java b/bundles/org.eclipse.e4.ui.workbench.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/ToolItemUpdater.java
@@ -55,7 +55,7 @@ public void updateContributionItems(Selector selector) {
 					if (timestampOfEarliestQueuedUpdate == 0) {
 						timestampOfEarliestQueuedUpdate = System.nanoTime();
 					}
-					if (System.nanoTime() - timestampOfEarliestQueuedUpdate > DELAY * 1_000_000) {
+					if (System.nanoTime() - timestampOfEarliestQueuedUpdate > DELAY * 1_000_000L) {
 						// runnable was not called within the last DELAY milliseconds, do it now.
 						// For scenario: a plugin is forcing that updateContributionItems is called
 						// again and again in less than given DELAY frequency. TimerExec would then

Original file line number	Diff line number	Diff line change
`@@ -55,7 +55,7 @@ public void updateContributionItems(Selector selector) {`
`55`	`55`	`if (timestampOfEarliestQueuedUpdate == 0) {`
`56`	`56`	`timestampOfEarliestQueuedUpdate = System.nanoTime();`
`57`	`57`	`}`
`58`		`- if (System.nanoTime() - timestampOfEarliestQueuedUpdate > DELAY * 1_000_000) {`
	`58`	`+ if (System.nanoTime() - timestampOfEarliestQueuedUpdate > DELAY * 1_000_000L) {`
`59`	`59`	`// runnable was not called within the last DELAY milliseconds, do it now.`
`60`	`60`	`// For scenario: a plugin is forcing that updateContributionItems is called`
`61`	`61`	`// again and again in less than given DELAY frequency. TimerExec would then`