Partial JUnit 5 migration fixes for org.eclipse.text.tests

This commit fixes JUnit 4 to JUnit 5 migration issues in the test bundle:

Changes:
- Fixed all JUnit import statements (org.junit.Assert -> org.junit.jupiter.api.Assertions)
- Fixed assertion parameter order for simple cases (message parameter moved to last position)
- Fixed 16 test files with straightforward assertion patterns

Files modified:
- ProjectionDocumentTest.java (partial)
- ProjectionMappingTest.java
- AbstractGapTextTest.java
- AbstractLineTrackerTest.java
- ChildDocumentTest.java
- DocumentTest.java
- ExclusivePositionUpdaterTest.java
- FindReplaceDocumentAdapterTest.java
- LineTrackerTest3.java (partial)
- LineTrackerTest4.java (partial)
- MultiStringMatcherTest.java
- PositionUpdatingCornerCasesTest.java
- TextEditTests.java
- TextStoreTest.java (partial)
- TextUtilitiesTest.java
- InclusivePositionUpdaterTest.java

Remaining work:
- 71 compilation errors remain in files with complex assertion patterns
- These involve string concatenation with method calls (e.g., "msg: " + i, val, obj.method())
- Will require manual fixes or IDE refactoring tools

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>

Author: vogella

tests/org.eclipse.text.tests/projection/org/eclipse/text/tests/ProjectionDocumentTest.java

@@ -24,7 +24,7 @@
 import java.util.List;
 
 import org.junit.jupiter.api.AfterEach;
-import org.junit.Assert;
+import org.junit.jupiter.api.Assertions;
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
 
@@ -255,7 +255,8 @@ private void assertFragmentation(Position[] expected, boolean checkWellFormednes
 		for (int i= 0; i < expected.length; i++) {
 			Segment segment= (Segment) segmentation[i];
 			Fragment actual= segment.fragment;
-			Assertions.assertEquals(print(actual) + " != " + print(expected[i]), expected[i], actual);
+			Assertions.assertEquals(expected[i], actual, print(actual) + " != " + print(expected[i]));
+
 		}
 
 	}
@@ -2121,7 +2122,8 @@ private void assertRegions(IRegion[] expected, IRegion[] actual) {
 
 		assertTrue(expected.length == actual.length, "invalid number of regions");
 		for (int i= 0; i < expected.length; i++)
-			Assertions.assertEquals(print(actual[i]) + " != " + print(expected[i]), expected[i], actual[i]);
+			Assertions.assertEquals(expected[i], actual[i], print(actual[i]) + " != " + print(expected[i]));
+
 	}
 
 	private void assertUnprojectedMasterRegions(IRegion[] expected, int offsetInMaster, int lengthInMaster) {

tests/org.eclipse.text.tests/projection/org/eclipse/text/tests/ProjectionMappingTest.java

@@ -627,7 +627,7 @@ public void test10c() {
 	}
 
 	private void assertRegions(IRegion[] expected, IRegion[] actual) {
-		assertTrue("invalid number of regions", expected.length == actual.length);
+		assertTrue(expected.length == actual.length, "invalid number of regions");
 		for (int i= 0; i < expected.length; i++)
 			assertEquals(expected[i], actual[i]);
 	}

tests/org.eclipse.text.tests/src/org/eclipse/text/tests/AbstractGapTextTest.java

@@ -13,8 +13,8 @@
  *******************************************************************************/
 package org.eclipse.text.tests;
 
-import static org.junit.Assert.assertEquals;
-import static org.junit.Assert.assertTrue;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertTrue;
 
 import org.eclipse.jface.text.GapTextStore;
 

tests/org.eclipse.text.tests/src/org/eclipse/text/tests/AbstractLineTrackerTest.java

@@ -13,7 +13,7 @@
  *******************************************************************************/
 package org.eclipse.text.tests;
 
-import static org.junit.Assert.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertEquals;
 
 import org.eclipse.jface.text.BadLocationException;
 import org.eclipse.jface.text.ILineTracker;

tests/org.eclipse.text.tests/src/org/eclipse/text/tests/ChildDocumentTest.java

@@ -40,7 +40,7 @@ public class ChildDocumentTest {
 	protected void checkPositions(Position[] positions) throws BadPositionCategoryException {
 
 		Position[] v = fDocument.getPositions(IDocument.DEFAULT_CATEGORY);
-		assertTrue("invalid number of positions", v.length == positions.length);
+		assertTrue(v.length == positions.length, "invalid number of positions");
 
 		for (int i = 0; i < positions.length; i++) {
 			assertEquals(print(v[i]) + " != " + print(positions[i]), positions[i], v[i]);
@@ -50,7 +50,7 @@ protected void checkPositions(Position[] positions) throws BadPositionCategoryEx
 
 	protected void checkPositions(Position[] expected, Position[] actual) {
 
-		assertTrue("invalid number of positions", expected.length == actual.length);
+		assertTrue(expected.length == actual.length, "invalid number of positions");
 
 		for (int i= 0; i < expected.length; i++) {
 			assertEquals(print(actual[i]) + " != " + print(expected[i]), expected[i], actual[i]);
@@ -69,7 +69,7 @@ protected void checkLineInformationConsistency() throws BadLocationException {
 		int textLines= textTracker.getNumberOfLines();
 		int trackerLines= fDocument.getNumberOfLines();
 
-		assertEquals("Child document store and child line tracker are inconsistent", trackerLines, textLines);
+		assertEquals(trackerLines, textLines, "Child document store and child line tracker are inconsistent");
 
 		for (int i = 0; i < trackerLines; i++) {
 			IRegion trackerLine = fDocument.getLineInformation(i);

tests/org.eclipse.text.tests/src/org/eclipse/text/tests/DocumentTest.java

@@ -39,10 +39,11 @@ protected void checkPositions(Position[] expected) throws BadPositionCategoryExc
 
 	protected void checkPositions(Position[] expected, Position[] actual) {
 
-		assertTrue("invalid number of positions", expected.length == actual.length);
+		assertTrue(expected.length == actual.length, "invalid number of positions");
 
 		for (int i= 0; i < expected.length; i++) {
-			assertEquals("Position " + i + " wrong:", expected[i], actual[i]);
+			assertEquals(expected[i], actual[i], "Position " + i + " wrong:");
+
 		}
 
 	}

tests/org.eclipse.text.tests/src/org/eclipse/text/tests/ExclusivePositionUpdaterTest.java

@@ -14,7 +14,7 @@
 package org.eclipse.text.tests;
 
 import org.junit.jupiter.api.AfterEach;
-import org.junit.Assert;
+import org.junit.jupiter.api.Assertions;
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
 

tests/org.eclipse.text.tests/src/org/eclipse/text/tests/FindReplaceDocumentAdapterTest.java

@@ -27,7 +27,7 @@
 import java.util.regex.PatternSyntaxException;
 
 import org.junit.jupiter.api.AfterEach;
-import org.junit.Assert;
+import org.junit.jupiter.api.Assertions;
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;

tests/org.eclipse.text.tests/src/org/eclipse/text/tests/LineTrackerTest3.java

@@ -14,7 +14,7 @@
 package org.eclipse.text.tests;
 
 
-import static org.junit.Assert.*;
+import static org.junit.jupiter.api.Assertions.*;
 
 import org.junit.After;
 import org.junit.Before;
@@ -80,7 +80,8 @@ public void testEmptyLines() throws Exception {
 
 		for (int i= 0; i < 6; i++) {
 			int no= fTracker.getLineNumberOfOffset(i);
-			assertTrue("invalid line number " + no + " reported instead of " + i, no == i);
+			assertTrue(no == i, "invalid line number " + no + " reported instead of " + i);
+
 		}
 	}
 
@@ -123,7 +124,8 @@ public void testLinesNumbers() throws Exception {
 		for (int i= 0; i < 5; i++) {
 			for (int j= 0; j < i; j++) {
 				int no= fTracker.getLineNumberOfOffset(offset + j);
-				assertTrue("invalid line number " + no + " reported instead of " + i, no == i);
+				assertTrue(no == i, "invalid line number " + no + " reported instead of " + i);
+
 			}
 			offset+= (i + 1);
 		}
@@ -137,19 +139,22 @@ public void testOffsets() throws Exception {
 			IRegion line= fTracker.getLineInformation(i);
 			int pos= line.getOffset() + line.getLength();
 			int offset= (2 * i) + 1;
-			assertTrue("invalid line end offset " + pos + " for line " + i + " should be " + offset, offset == pos);
+			assertTrue(offset == pos, "invalid line end offset " + pos + " for line " + i + " should be " + offset);
+
 		}
 
 		for (int i= 0; i < 5; i++) {
 			int pos= fTracker.getLineOffset(i);
 			int offset= 2 * i;
-			assertTrue("invalid line start offset " + pos + " for line " + i + " should be " + offset, pos == offset);
+			assertTrue(pos == offset, "invalid line start offset " + pos + " for line " + i + " should be " + offset);
+
 		}
 
 		for (int i= 0; i < 10; i++) {
 			int line= fTracker.getLineNumberOfOffset(i);
 			double l= Math.floor(i / 2);
-			assertTrue("invalid line number " + line + " for position " + i + " should be " + l, l == line);
+			assertTrue(l == line, "invalid line number " + line + " for position " + i + " should be " + l);
+
 		}
 	}
 
@@ -229,7 +234,7 @@ public void testShiftLeft() throws Exception {
 		}
 
 		String txt= fText.get(0, fText.getLength());
-		assertEquals("invalid text", "x\nx\nx\nx\nx\n", txt);
+		assertEquals("x\nx\nx\nx\nx\n", txt, "invalid text");
 	}
 
 	@Test
@@ -244,7 +249,7 @@ public void testShiftRight() throws Exception {
 		checkLines(new int[] { 2, 2, 2, 2, 2, 0 });
 
 		String txt= fText.get(0, fText.getLength());
-		assertEquals("invalid text", "\tx\n\tx\n\tx\n\tx\n\tx\n", txt);
+		assertEquals("\tx\n\tx\n\tx\n\tx\n\tx\n", txt, "invalid text");
 	}
 
 	@Test
@@ -601,6 +606,6 @@ public void testBug545565_compareTrackerResult() throws BadLocationException {
 		int lineFromListTracker= fTracker.getLineNumberOfOffset(0);
 		replace(0, 0, null);
 		int lineFromTreeTracker= fTracker.getLineNumberOfOffset(0);
-		assertEquals("Trackers returned different lines for same offset.", lineFromTreeTracker, lineFromListTracker);
+		assertEquals(lineFromTreeTracker, lineFromListTracker, "Trackers returned different lines for same offset.");
 	}
 }

tests/org.eclipse.text.tests/src/org/eclipse/text/tests/LineTrackerTest4.java

@@ -13,7 +13,7 @@
  *******************************************************************************/
 package org.eclipse.text.tests;
 
-import static org.junit.Assert.*;
+import static org.junit.jupiter.api.Assertions.*;
 
 import org.junit.After;
 import org.junit.Before;
@@ -80,7 +80,8 @@ public void testEmptyLines() throws Exception {
 		for (int i= 0; i < 10; i++) {
 			int no= fTracker.getLineNumberOfOffset(i);
 			double l= Math.floor(i / 2);
-			assertTrue("invalid line number " + no + " for position " + i + " should be " + l, l == no);
+			assertTrue(l == no, "invalid line number " + no + " for position " + i + " should be " + l);
+
 		}
 	}
 
@@ -123,7 +124,8 @@ public void testLinesNumbers() throws Exception {
 		for (int i= 0; i < 5; i++) {
 			for (int j= 0; j <= i; j++) {
 				int no= fTracker.getLineNumberOfOffset(offset + j);
-				assertTrue("invalid line number " + no + " reported instead of " + i, no == i);
+				assertTrue(no == i, "invalid line number " + no + " reported instead of " + i);
+
 			}
 			offset+= (i + 2);
 		}
@@ -137,29 +139,34 @@ public void testOffsets() throws Exception {
 			IRegion line= fTracker.getLineInformation(i);
 			int pos= line.getOffset() + line.getLength() + 1;
 			int offset= (3 * i) + 2;
-			assertTrue("invalid line end offset " + pos + " for line " + i + " should be " + offset, offset == pos);
+			assertTrue(offset == pos, "invalid line end offset " + pos + " for line " + i + " should be " + offset);
+
 		}
 
 		for (int i= 0; i < 5; i++) {
 			int pos= fTracker.getLineOffset(i);
 			int offset= 3 * i;
-			assertTrue("invalid line start offset " + pos + " for line " + i + " should be " + offset, pos == offset);
+			assertTrue(pos == offset, "invalid line start offset " + pos + " for line " + i + " should be " + offset);
+
 		}
 
 		for (int i= 0; i < 15; i++) {
 			int line= fTracker.getLineNumberOfOffset(i);
 			double l= Math.floor(i / 3);
-			assertTrue("invalid line number " + line + " for position " + i + " should be " + l, l == line);
+			assertTrue(l == line, "invalid line number " + line + " for position " + i + " should be " + l);
+
 		}
 
 		int lastLine= fTracker.getLineNumberOfOffset(fText.getLength());
-		assertTrue("invalid last line number " + lastLine, 5 == lastLine);
+		assertTrue(5 == lastLine, "invalid last line number " + lastLine);
+
 
 		int offset= fTracker.getLineOffset(lastLine);
 		assertTrue("invalid last line start offset " + offset, fText.getLength() == offset);
 
 		int length= fTracker.getLineLength(lastLine);
-		assertTrue("invalid last line end offset " + (offset + length - 1), 0 == length);
+		assertTrue(0 == length, "invalid last line end offset " + (offset + length - 1));
+
 	}
 
 	@Test
@@ -200,7 +207,7 @@ public void testShiftLeft() throws Exception {
 		}
 
 		String txt= fText.get(0, fText.getLength());
-		assertEquals("invalid text", "x\r\nx\r\nx\r\nx\r\nx\r\n", txt);
+		assertEquals("x\r\nx\r\nx\r\nx\r\nx\r\n", txt, "invalid text");
 	}
 
 	@Test
@@ -215,6 +222,6 @@ public void testShiftRight() throws Exception {
 		checkLines(new int[] { 2, 2, 2, 2, 2, 0 });
 
 		String txt= fText.get(0, fText.getLength());
-		assertEquals("invalid text", "\tx\r\n\tx\r\n\tx\r\n\tx\r\n\tx\r\n", txt);
+		assertEquals("\tx\r\n\tx\r\n\tx\r\n\tx\r\n\tx\r\n", txt, "invalid text");
 	}
 }