Workaround for unexpected scrollbars

This commit adds two additional points to the width and height
when calculating the size of the composite containing the Hyperlinks in
the MultipleHyperlinkPresenter. Additionally this refreshes the size of
the parent shell to prevent additional scrollbars in some zoom levels.
This serves as a workaround for a current limitation in the SWT
implementation on Windows. With certain zoom settings (e.g., 125%, 175%
or 225%), the calculated size may be too small, causing the Composite to
show Scrollbars, although it calculated to not need scrollbars. This
additional width/height is only added for windows and when no
scrollbars should be thrown.

Author: akoch-yatta

bundles/org.eclipse.jface.text/src/org/eclipse/jface/text/hyperlink/MultipleHyperlinkPresenter.java

@@ -39,6 +39,8 @@
 import org.eclipse.swt.widgets.Table;
 import org.eclipse.swt.widgets.TableItem;
 
+import org.eclipse.core.runtime.Platform.OS;
+
 import org.eclipse.jface.preference.IPreferenceStore;
 import org.eclipse.jface.resource.JFaceResources;
 import org.eclipse.jface.util.Geometry;
@@ -152,6 +154,15 @@ public LinkListInformationControl(Shell parentShell, MultipleHyperlinkHoverManag
 			fForegroundColor= foregroundColor;
 			fBackgroundColor= backgroundColor;
 			create();
+			getShell().addListener(SWT.ZoomChanged, event -> {
+				final Shell shell= getShell();
+				final Display display= shell.getDisplay();
+				display.asyncExec(() -> {
+					if (!display.isDisposed()) {
+						shell.setSize(computeSizeHint());
+					}
+				});
+			});
 		}
 
 		@Override
@@ -217,6 +228,13 @@ public Point computeSizeHint() {
 			int width;
 			if (preferedSize.y - scrollBarHeight <= constraints.y) {
 				width= preferedSize.x - scrollBarWidth;
+				if (OS.isWindows()) {
+					/*
+					 * compensate rounding issue in windows
+					 * +1 for preferedSize and +1 for scrollBarWidth
+					 */
+					width+= 2;
+				}
 				fTable.getVerticalBar().setVisible(false);
 			} else {
 				width= Math.min(preferedSize.x, constraints.x);
@@ -225,6 +243,13 @@ public Point computeSizeHint() {
 			int height;
 			if (preferedSize.x - scrollBarWidth <= constraints.x) {
 				height= preferedSize.y - scrollBarHeight;
+				if (OS.isWindows()) {
+					/*
+					 * compensate rounding issue in windows
+					 * +1 for preferedSize and +1 for scrollBarHeight
+					 */
+					height+= 2;
+				}
 				fTable.getHorizontalBar().setVisible(false);
 			} else {
 				height= Math.min(preferedSize.y, constraints.y);