remove redundant MatchEvent.fMatchContainer

Only either fMatchContainer or fMatches could have been set. There is no
point in trying to avoid allocating the array - it can not be reused in
parallel anyway

Author: Jörg Kubitz

bundles/org.eclipse.search/newsearch/org/eclipse/search/ui/text/MatchEvent.java

@@ -24,10 +24,9 @@
  * @since 3.0
  */
 public class MatchEvent extends SearchResultEvent {
-	private static final long serialVersionUID = 6009335074727417445L;
+	private static final long serialVersionUID = 6009335074727417446L;
 	private int fKind;
 	private Match[] fMatches;
-	private Match[] fMatchContainer = new Match[1];
 	/**
 	 * Constant for a matches being added.
 	 *
@@ -68,8 +67,6 @@ public int getKind() {
 	public Match[] getMatches() {
 		if (fMatches != null)
 			return fMatches;
-		else if (fMatchContainer[0] != null)
-			return fMatchContainer;
 		else
 			return fgEmtpyMatches;
 	}
@@ -88,8 +85,9 @@ protected void setKind(int kind) {
 	 * @param match the match to set
 	 */
 	protected void setMatch(Match match) {
-		fMatchContainer[0] = match;
-		fMatches = null;
+		Match[] matches = new Match[1];
+		matches[0] = match;
+		fMatches = matches;
 	}
 
 	/**
@@ -98,7 +96,6 @@ protected void setMatch(Match match) {
 	 * @param matches the matches to set
 	 */
 	protected void setMatches(Match[] matches) {
-		fMatchContainer[0] = null;
 		fMatches = matches;
 	}
 }