Remove done() call on SubMonitor in Refactoring

vogella · vogella · commit aaddfd6beb80 · 2024-12-03T16:04:54.000+01:00
done() call not necessary here See https://www.eclipse.org/articles/Article-Progress-Monitors/article.html
diff --git a/bundles/org.eclipse.ltk.core.refactoring/src/org/eclipse/ltk/core/refactoring/Refactoring.java b/bundles/org.eclipse.ltk.core.refactoring/src/org/eclipse/ltk/core/refactoring/Refactoring.java
@@ -162,7 +162,6 @@ public RefactoringStatus checkAllConditions(IProgressMonitor pm) throws CoreExce
 		if (!result.hasFatalError()) {
 			result.merge(checkFinalConditions(subMon.split(refactoringTickProvider.getCheckFinalConditionsTicks())));
 		}
-		subMon.done();
 		return result;
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -162,7 +162,6 @@ public RefactoringStatus checkAllConditions(IProgressMonitor pm) throws CoreExce`
`162`	`162`	`if (!result.hasFatalError()) {`
`163`	`163`	`result.merge(checkFinalConditions(subMon.split(refactoringTickProvider.getCheckFinalConditionsTicks())));`
`164`	`164`	`}`
`165`		`- subMon.done();`
`166`	`165`	`return result;`
`167`	`166`	`}`
`168`	`167`