Skip to content

Commit b93e2df

Browse files
Bugfix for Hover which is visible above other application windows. #2534
This patch is fixing the problem, where the HoverManagers listeners are deregistered but the hover is still visibile on top. This happens when the hover was sticky eclipse was minimized and put back on foreground after it. In that case the listeners are already deregistered and there is no chance to react at all. So for this case the visibility has to be set explicitly when the close is going to stop. Version bump(s) for 4.35 stream Bugfix for Hover which is visible above other application windows. #2534
1 parent 7aaa014 commit b93e2df

File tree

2 files changed

+10
-2
lines changed

2 files changed

+10
-2
lines changed

bundles/org.eclipse.jface.text/META-INF/MANIFEST.MF

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
22
Bundle-ManifestVersion: 2
33
Bundle-Name: %pluginName
44
Bundle-SymbolicName: org.eclipse.jface.text
5-
Bundle-Version: 3.26.0.qualifier
5+
Bundle-Version: 3.26.100.qualifier
66
Bundle-Vendor: %providerName
77
Bundle-Localization: plugin
88
Export-Package:

bundles/org.eclipse.jface.text/src/org/eclipse/jface/text/AbstractInformationControlManager.java

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424
import org.eclipse.swt.widgets.Control;
2525
import org.eclipse.swt.widgets.Display;
2626
import org.eclipse.swt.widgets.Monitor;
27+
import org.eclipse.swt.widgets.Shell;
2728

2829
import org.eclipse.core.runtime.Assert;
2930
import org.eclipse.core.runtime.Platform;
@@ -1210,8 +1211,15 @@ protected void hideInformationControl() {
12101211
if (fInformationControl != null) {
12111212
storeInformationControlBounds();
12121213
fInformationControl.setVisible(false);
1213-
if (fInformationControlCloser != null)
1214+
if (fInformationControlCloser != null) {
12141215
fInformationControlCloser.stop();
1216+
}
1217+
if (fInformationControl instanceof AbstractInformationControl infoControl) {
1218+
Shell shell= infoControl.getShell();
1219+
if (!shell.isDisposed()) {
1220+
shell.setVisible(false);
1221+
}
1222+
}
12151223
}
12161224
if (canClearDataOnHide()) {
12171225
fSubjectArea= null;

0 commit comments

Comments
 (0)