Bugfix for Hover which is visible above other application windows. #2534

This patch is fixing the problem, where the HoverManagers listeners are
deregistered but the hover is still visibile on top. This happens when
the hover was sticky eclipse was minimized and put back on foreground
after it. In that case the listeners are already deregistered and there
is no chance to react at all. So for this case the visibility has to be
set explicitly when the close is going to stop.

Author: mehmet-karaman

bundles/org.eclipse.jface.text/src/org/eclipse/jface/internal/text/StickyHoverManager.java

@@ -28,9 +28,11 @@
 import org.eclipse.swt.widgets.Display;
 import org.eclipse.swt.widgets.Event;
 import org.eclipse.swt.widgets.Listener;
+import org.eclipse.swt.widgets.Shell;
 
 import org.eclipse.jface.util.Geometry;
 
+import org.eclipse.jface.text.AbstractInformationControl;
 import org.eclipse.jface.text.IInformationControl;
 import org.eclipse.jface.text.IInformationControlExtension3;
 import org.eclipse.jface.text.IInformationControlExtension5;
@@ -142,6 +144,14 @@ public void stop() {
 			if (fInformationControlToClose != null)
 				fInformationControlToClose.removeFocusListener(this);
 
+			// Was added to fix the bug #2534
+			if (fInformationControlToClose instanceof AbstractInformationControl infoControl) {
+				Shell shell= infoControl.getShell();
+				if (!shell.isDisposed()) {
+					shell.setVisible(false);
+				}
+			}
+
 			if (fDisplay != null && !fDisplay.isDisposed()) {
 				fDisplay.removeFilter(SWT.MouseMove, this);
 				fDisplay.removeFilter(SWT.FocusOut, this);