Skip to content

Commit c44c4e7

Browse files
eclipse-platform-botakurtakov
authored andcommitted
Perform clean code of bundles/org.eclipse.jface.notifications
1 parent 12a8986 commit c44c4e7

File tree

1 file changed

+9
-7
lines changed

1 file changed

+9
-7
lines changed

bundles/org.eclipse.jface.notifications/src/org/eclipse/jface/notifications/NotificationPopup.java

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ public class NotificationPopup extends AbstractNotificationPopup {
5757
*/
5858
public static class Builder {
5959

60-
private Display display;
60+
private final Display display;
6161
private Function<Composite, Control> contentCreator;
6262
private Function<Composite, Control> titleCreator;
6363
private Long delay;
@@ -204,10 +204,10 @@ public static Builder forShell(Shell shell) {
204204
return new Builder(shell.getDisplay()).shell(shell);
205205
}
206206

207-
private Function<Composite, ? extends Control> contentCreator;
208-
private Function<Composite, Control> titleCreator;
209-
private boolean hasCloseButton;
210-
private Image titleImage;
207+
private final Function<Composite, ? extends Control> contentCreator;
208+
private final Function<Composite, Control> titleCreator;
209+
private final boolean hasCloseButton;
210+
private final Image titleImage;
211211

212212
private NotificationPopup(Builder builder) {
213213
super(builder.display);
@@ -237,10 +237,12 @@ protected void createTitleArea(Composite parent) {
237237
((GridData) parent.getLayoutData()).heightHint = TITLE_HEIGHT;
238238

239239
int numColums = 1;
240-
if (hasCloseButton)
240+
if (hasCloseButton) {
241241
numColums++;
242-
if (titleImage != null)
242+
}
243+
if (titleImage != null) {
243244
numColums++;
245+
}
244246
GridLayoutFactory.fillDefaults().numColumns(numColums).applyTo(parent);
245247

246248
if (titleImage != null) {

0 commit comments

Comments
 (0)