Fixup : Testing and fixing CI

Author: elsazac

bundles/org.eclipse.e4.ui.workbench.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/StackRenderer.java

@@ -89,8 +89,6 @@
 import org.eclipse.swt.custom.CTabItem;
 import org.eclipse.swt.dnd.DND;
 import org.eclipse.swt.dnd.DropTarget;
-import org.eclipse.swt.dnd.TextTransfer;
-import org.eclipse.swt.dnd.Transfer;
 import org.eclipse.swt.events.ControlEvent;
 import org.eclipse.swt.events.ControlListener;
 import org.eclipse.swt.events.MouseAdapter;
@@ -723,21 +721,12 @@ public Object createWidget(MUIElement element, Object parent) {
 		int styleOverride = getStyleOverride(pStack);
 		int style = styleOverride == -1 ? SWT.BORDER : styleOverride;
 		CTabFolder tabFolder = new CTabFolder(parentComposite, style);
-//		if (PartStackUtil.isEditorStack(element)) {
-//			createOnboardingControls(tabFolder);
-//			initializeOnboardingInformationInEditorStack(tabFolder);
-//			Shell shell = Display.getCurrent().getActiveShell();
-//			new DropTarget(shell, DND.DROP_COPY | DND.DROP_MOVE | DND.DROP_LINK);
-//		}
-
 		if (PartStackUtil.isEditorStack(element)) {
 			createOnboardingControls(tabFolder);
 			initializeOnboardingInformationInEditorStack(tabFolder);
 			Label dropLabel = new Label(tabFolder, SWT.NONE);
-			dropLabel.setText("Drop here"); //$NON-NLS-1$
 			int drop = DND.DROP_COPY | DND.DROP_MOVE | DND.DROP_LINK;
-			DropTarget target = new DropTarget(dropLabel, drop);
-			target.setTransfer(new Transfer[] { TextTransfer.getInstance() }); // or FileTransfer, etc.
+			new DropTarget(dropLabel, drop);
 		}
 		tabFolder.setMRUVisible(getMRUValue());
 		// Adjust the minimum chars based on the location

tests/org.eclipse.e4.ui.tests/src/org/eclipse/e4/ui/workbench/renderers/swt/StackRendererTest.java

@@ -417,7 +417,7 @@ public void testOnboardingRenderedWithCorrectSizeForEditorStack() {
 		Composite uiContainer = (Composite) ((StackRenderer) partStack.getRenderer()).getUIContainer(partStack);
 		CTabFolder tabFolder = (CTabFolder) ((Composite) uiContainer.getChildren()[0]).getChildren()[0];
 		assertNotNull(tabFolder.getChildren());
-		assertEquals(3, tabFolder.getChildren().length);
+		assertEquals(4, tabFolder.getChildren().length);
 
 		Composite outerOnboardingComposite = (Composite) tabFolder.getChildren()[2];
 		Rectangle expected = new Rectangle(StackRenderer.ONBOARDING_SPACING, StackRenderer.ONBOARDING_TOP_SPACING,
@@ -526,7 +526,7 @@ public void testOnboardingIsHiddenWhenEditorOpened() {
 		Composite uiContainer = (Composite) ((StackRenderer) partStack.getRenderer()).getUIContainer(partStack);
 		CTabFolder tabFolder = (CTabFolder) ((Composite) uiContainer.getChildren()[0]).getChildren()[0];
 		assertNotNull(tabFolder.getChildren());
-		assertEquals(3, tabFolder.getChildren().length);
+		assertEquals(4, tabFolder.getChildren().length);
 
 		Composite outerOnboardingComposite = (Composite) tabFolder.getChildren()[2];
 		Rectangle expected = new Rectangle(StackRenderer.ONBOARDING_SPACING, StackRenderer.ONBOARDING_TOP_SPACING,