Skip to content

Commit d0b5059

Browse files
committed
Add test case for recursive marker content generator extensions #2193
1 parent 9416088 commit d0b5059

File tree

2 files changed

+31
-4
lines changed

2 files changed

+31
-4
lines changed

tests/org.eclipse.ui.tests/Eclipse UI Tests/org/eclipse/ui/tests/markers/MarkerSupportViewTest.java

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -142,15 +142,23 @@ public void markerContentGeneratorExtensionLoaded() throws Exception {
142142

143143
MarkerField[] allFields = descriptor.getAllFields();
144144

145-
boolean foundAdditionalFieldRegisteredViaExtension = false;
145+
boolean foundAdditionalField1 = false;
146+
boolean foundRecursivelyAddedField2 = false;
146147
for (MarkerField field : allFields) {
147148
if (ProblemKeyMarkerField.class.equals(field.getClass())) {
148-
foundAdditionalFieldRegisteredViaExtension = true;
149-
break;
149+
if ("Problem Key".equals(field.getName())) {
150+
foundAdditionalField1 = true;
151+
}
152+
153+
if ("Problem Key V2".equals(field.getName())) {
154+
foundRecursivelyAddedField2 = true;
155+
}
150156
}
151157
}
152158
assertTrue("MarkerFields from marker content generator extensions not loaded.",
153-
foundAdditionalFieldRegisteredViaExtension);
159+
foundAdditionalField1);
160+
assertTrue("MarkerField not loaded from recursive marker content generator extension.",
161+
foundRecursivelyAddedField2);
154162

155163
MarkerType markerTypeFromExtension = descriptor.getType("org.eclipse.ui.tests.markers.artificial.problem");
156164
assertNotNull("Marker type from marker content generator extensions not loaded.", markerTypeFromExtension);

tests/org.eclipse.ui.tests/plugin.xml

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3417,6 +3417,11 @@
34173417
id="org.eclipse.ui.tests.markerField.problemKey"
34183418
name="Problem Key">
34193419
</markerField>
3420+
<markerField
3421+
class="org.eclipse.ui.tests.markers.ProblemKeyMarkerField"
3422+
id="org.eclipse.ui.tests.markerField.problemKeyV2"
3423+
name="Problem Key V2">
3424+
</markerField>
34203425
<markerContentGenerator
34213426
id="org.eclipse.ui.tests.additionalProblemMarkerContentGenerator"
34223427
name="Additional Problem Marker Content Generator">
@@ -3441,6 +3446,20 @@
34413446
<markerContentGeneratorExtension
34423447
generatorId="org.eclipse.ui.ide.allMarkersGenerator"
34433448
id="org.eclipse.ui.tests.additionalProblemMarkerContentGenerator">
3449+
</markerContentGeneratorExtension>
3450+
<markerContentGenerator
3451+
id="org.eclipse.ui.tests.additionalProblemMarkerContentGenerator2"
3452+
name="Additional Problem Marker Content Generator 2">
3453+
<markerFieldReference
3454+
id="org.eclipse.ui.tests.markerField.problemKeyV2">
3455+
</markerFieldReference>
3456+
<markerTypeReference
3457+
id="org.eclipse.ui.tests.markers.static.analysis.problem">
3458+
</markerTypeReference>
3459+
</markerContentGenerator>
3460+
<markerContentGeneratorExtension
3461+
generatorId="org.eclipse.ui.tests.additionalProblemMarkerContentGenerator"
3462+
id="org.eclipse.ui.tests.additionalProblemMarkerContentGenerator2">
34443463
</markerContentGeneratorExtension>
34453464
</extension>
34463465
<extension

0 commit comments

Comments
 (0)