Fix race condition in ResourceInitialSelectionTest by waiting for async jobs

Add DisplayHelper.waitForCondition() calls to wait for background jobs
(FilterHistoryJob, FilterJob) to complete before checking the selection.
This prevents intermittent test failures on macOS where the table hasn't
been populated yet when getSelectedItems() is called.

Fixes: #1108

Co-authored-by: vogella <[email protected]>

Author: Copilot

tests/org.eclipse.ui.tests/Eclipse UI Tests/org/eclipse/ui/tests/dialogs/ResourceInitialSelectionTest.java

@@ -82,6 +82,9 @@ public void testSingleSelectionAndNoInitialSelectionWithInitialPattern() {
 		dialog.open();
 		dialog.refresh();
 
+		Display display = PlatformUI.getWorkbench().getDisplay();
+		DisplayHelper.waitForCondition(display, 3000, () -> !getSelectedItems(dialog).isEmpty());
+
 		List<Object> selected = getSelectedItems(dialog);
 
 		assertFalse("One file should be selected by default", selected.isEmpty());
@@ -100,6 +103,10 @@ public void testSingleSelectionAndOneInitialSelectionWithInitialPattern() {
 		dialog.open();
 		dialog.refresh();
 
+		Display display = PlatformUI.getWorkbench().getDisplay();
+		DisplayHelper.waitForCondition(display, 3000,
+				() -> asList(FILES.get("foo.txt")).equals(getSelectedItems(dialog)));
+
 		List<Object> selected = getSelectedItems(dialog);
 
 		assertEquals("One file should be selected by default", asList(FILES.get("foo.txt")), selected);
@@ -174,6 +181,10 @@ public void testSingleSelectionAndTwoInitialSelectionsWithInitialPattern() {
 		dialog.open();
 		dialog.refresh();
 
+		Display display = PlatformUI.getWorkbench().getDisplay();
+		DisplayHelper.waitForCondition(display, 3000,
+				() -> asList(FILES.get("foo.txt")).equals(getSelectedItems(dialog)));
+
 		List<Object> selected = getSelectedItems(dialog);
 
 		assertEquals("The first file should be selected by default", asList(FILES.get("foo.txt")), selected);
@@ -192,6 +203,9 @@ public void testMultiSelectionAndNoInitialSelectionWithInitialPattern() {
 		dialog.open();
 		dialog.refresh();
 
+		Display display = PlatformUI.getWorkbench().getDisplay();
+		DisplayHelper.waitForCondition(display, 3000, () -> !getSelectedItems(dialog).isEmpty());
+
 		List<Object> selected = getSelectedItems(dialog);
 
 		assertFalse("One file should be selected by default", selected.isEmpty());
@@ -211,6 +225,10 @@ public void testMultiSelectionAndOneInitialSelectionWithInitialPattern() {
 		dialog.open();
 		dialog.refresh();
 
+		Display display = PlatformUI.getWorkbench().getDisplay();
+		DisplayHelper.waitForCondition(display, 3000,
+				() -> asList(FILES.get("foo.txt")).equals(getSelectedItems(dialog)));
+
 		List<Object> selected = getSelectedItems(dialog);
 
 		assertEquals("One file should be selected by default", asList(FILES.get("foo.txt")), selected);
@@ -266,8 +284,12 @@ public void testMultiSelectionAndSomeInitialNonExistingSelectionWithInitialPatte
 		dialog.open();
 		dialog.refresh();
 
-		List<Object> selected = getSelectedItems(dialog);
+		Display display = PlatformUI.getWorkbench().getDisplay();
 		Set<IFile> expectedSelection = new HashSet<>(asList(FILES.get("bar.txt"), FILES.get("foofoo")));
+		DisplayHelper.waitForCondition(display, 3000,
+				() -> expectedSelection.equals(new HashSet<>(getSelectedItems(dialog))));
+
+		List<Object> selected = getSelectedItems(dialog);
 		boolean allInitialElementsAreSelected = expectedSelection.equals(new HashSet<>(selected));
 
 		assertTrue("Two files should be selected by default", allInitialElementsAreSelected);
@@ -288,6 +310,12 @@ public void testMultiSelectionAndTwoInitialSelectionsWithInitialPattern() {
 		dialog.open();
 		dialog.refresh();
 
+		Display display = PlatformUI.getWorkbench().getDisplay();
+		DisplayHelper.waitForCondition(display, 3000, () -> {
+			List<Object> selected = getSelectedItems(dialog);
+			return selected.containsAll(initialSelection) && initialSelection.containsAll(selected);
+		});
+
 		List<Object> selected = getSelectedItems(dialog);
 		boolean initialElementsAreSelected = selected.containsAll(initialSelection)
 				&& initialSelection.containsAll(selected);
@@ -310,8 +338,14 @@ public void testMultiSelectionAndTwoInitialFilteredSelections() {
 		dialog.open();
 		dialog.refresh();
 
-		List<Object> selected = getSelectedItems(dialog);
+		Display display = PlatformUI.getWorkbench().getDisplay();
 		List<IFile> expectedSelection = asList(FILES.get("foo.txt"), FILES.get("bar.txt"));
+		DisplayHelper.waitForCondition(display, 3000, () -> {
+			List<Object> selected = getSelectedItems(dialog);
+			return selected.containsAll(expectedSelection) && expectedSelection.containsAll(selected);
+		});
+
+		List<Object> selected = getSelectedItems(dialog);
 		boolean initialElementsAreSelected = selected.containsAll(expectedSelection)
 				&& expectedSelection.containsAll(selected);