Skip to content

Commit e19f934

Browse files
shubhamWaghmare-sapmerks
authored andcommitted
Set min chars to MAX_VIEW_CHARS when show full titles pref is enabled
1 parent e79c37e commit e19f934

File tree

1 file changed

+2
-6
lines changed
  • bundles/org.eclipse.e4.ui.workbench.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt

1 file changed

+2
-6
lines changed

bundles/org.eclipse.e4.ui.workbench.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/CTabRendering.java

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818
package org.eclipse.e4.ui.workbench.renderers.swt;
1919

2020
import java.lang.reflect.Field;
21-
import java.util.Arrays;
2221
import java.util.Objects;
2322
import org.eclipse.core.runtime.preferences.IEclipsePreferences;
2423
import org.eclipse.core.runtime.preferences.IEclipsePreferences.IPreferenceChangeListener;
@@ -34,7 +33,6 @@
3433
import org.eclipse.swt.SWT;
3534
import org.eclipse.swt.custom.CTabFolder;
3635
import org.eclipse.swt.custom.CTabFolderRenderer;
37-
import org.eclipse.swt.custom.CTabItem;
3836
import org.eclipse.swt.graphics.Color;
3937
import org.eclipse.swt.graphics.GC;
4038
import org.eclipse.swt.graphics.Image;
@@ -90,7 +88,7 @@ public class CTabRendering extends CTabFolderRenderer implements ICTabRendering,
9088
public static final boolean SHOW_FULL_TEXT_FOR_VIEW_TABS_DEFAULT = false;
9189

9290
private static int MIN_VIEW_CHARS = 1;
93-
private static int MAX_VIEW_CHARS = 9999;
91+
private static int MAX_VIEW_CHARS = 999999;
9492

9593
// Constants for circle drawing
9694
static enum CirclePart {
@@ -1305,9 +1303,7 @@ private void showFullTextForViewTabsPreferenceChanged() {
13051303
boolean showFullText = getShowFullTextForViewTabsPreference();
13061304
if (!isPartOfEditorStack()) {
13071305
if (showFullText) {
1308-
int lengthOfLongestItemText = Arrays.stream(parent.getItems()).map(CTabItem::getText)
1309-
.map(String::length).max(Integer::compare).orElse(0);
1310-
parent.setMinimumCharacters(Math.max(MAX_VIEW_CHARS, lengthOfLongestItemText));
1306+
parent.setMinimumCharacters(MAX_VIEW_CHARS);
13111307
} else {
13121308
parent.setMinimumCharacters(MIN_VIEW_CHARS);
13131309
}

0 commit comments

Comments
 (0)