Skip to content

Commit e2ac13e

Browse files
Jörg Kubitzjukzi
authored andcommitted
fix GlobalTemplateVariablesDateTest #2649
using "year" instead of "week year" #2649
1 parent 3b4a7ab commit e2ac13e

File tree

1 file changed

+20
-11
lines changed

1 file changed

+20
-11
lines changed

tests/org.eclipse.text.tests/src/org/eclipse/text/tests/templates/GlobalTemplateVariablesDateTest.java

Lines changed: 20 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -64,40 +64,42 @@ public void testWithoutParameter() throws Exception {
6464

6565
@Test
6666
public void testOneParameter() throws Exception {
67-
TemplateBuffer buffer= fTranslator.translate("This format ${d:date('dd MMM YYYY')} and not ${p:date('YYYY-MM-dd')}");
67+
TemplateBuffer buffer = fTranslator
68+
.translate("This format ${d:date('dd MMM yyyy')} and not ${p:date('yyyy-MM-dd')}");
6869
fType.resolve(buffer, fContext);
6970

7071
StringBuilder expected= new StringBuilder();
7172
expected.append("This format ");
72-
expected.append(new SimpleDateFormat("dd MMM YYYY").format(new java.util.Date()));
73+
expected.append(new SimpleDateFormat("dd MMM yyyy").format(new java.util.Date()));
7374
expected.append(" and not ");
74-
expected.append(new SimpleDateFormat("YYYY-MM-dd").format(new java.util.Date()));
75+
expected.append(new SimpleDateFormat("yyyy-MM-dd").format(new java.util.Date()));
7576
assertBufferStringAndVariables(expected.toString(), buffer);
7677
}
7778

7879
@Test
7980
public void testSimpleLocale() throws Exception {
80-
TemplateBuffer buffer= fTranslator.translate("From ${d:date('dd MMM YYYY', 'fr')} to ${d}");
81+
TemplateBuffer buffer = fTranslator.translate("From ${d:date('dd MMM yyyy', 'fr')} to ${d}");
8182
fType.resolve(buffer, fContext);
8283

8384
StringBuilder expected= new StringBuilder();
8485
expected.append("From ");
85-
expected.append(new SimpleDateFormat("dd MMM YYYY", Locale.FRENCH).format(new java.util.Date()));
86+
expected.append(new SimpleDateFormat("dd MMM yyyy", Locale.FRENCH).format(new java.util.Date()));
8687
expected.append(" to ");
87-
expected.append(new SimpleDateFormat("dd MMM YYYY", Locale.FRENCH).format(new java.util.Date()));
88+
expected.append(new SimpleDateFormat("dd MMM yyyy", Locale.FRENCH).format(new java.util.Date()));
8889
assertBufferStringAndVariables(expected.toString(), buffer);
8990
}
9091

9192
@Test
9293
public void testComplexLocale() throws Exception {
93-
TemplateBuffer buffer= fTranslator.translate("France ${d:date('EEEE dd MMMM YYYY', 'fr_FR')} and Germany ${p:date('EEEE dd. MMMM YYYY', 'de_DE')}");
94+
TemplateBuffer buffer = fTranslator.translate(
95+
"France ${d:date('EEEE dd MMMM yyyy', 'fr_FR')} and Germany ${p:date('EEEE dd. MMMM yyyy', 'de_DE')}");
9496
fType.resolve(buffer, fContext);
9597

9698
StringBuilder expected= new StringBuilder();
9799
expected.append("France ");
98-
expected.append(new SimpleDateFormat("EEEE dd MMMM YYYY", Locale.FRANCE).format(new java.util.Date()));
100+
expected.append(new SimpleDateFormat("EEEE dd MMMM yyyy", Locale.FRANCE).format(new java.util.Date()));
99101
expected.append(" and Germany ");
100-
expected.append(new SimpleDateFormat("EEEE dd. MMMM YYYY", Locale.GERMANY).format(new java.util.Date()));
102+
expected.append(new SimpleDateFormat("EEEE dd. MMMM yyyy", Locale.GERMANY).format(new java.util.Date()));
101103
assertBufferStringAndVariables(expected.toString(), buffer);
102104
}
103105

@@ -115,13 +117,20 @@ public void testInvalidDateFormat() throws Exception {
115117

116118
@Test
117119
public void testInvalidLocale() throws Exception {
118-
TemplateBuffer buffer= fTranslator.translate("Today is ${d:date('YYYY-MM-dd', 'this_invalid_locale')}!");
120+
@SuppressWarnings("deprecation")
121+
java.util.Date problemDate = new java.util.Date(2024 - 1900, 12 - 1, 29);
122+
assertEquals("2024-12-29",
123+
new SimpleDateFormat("yyyy-MM-dd", Locale.GERMAN)
124+
.format(problemDate).toString());
125+
assertEquals("2025-12-29", new SimpleDateFormat("YYYY-MM-dd", Locale.GERMAN)
126+
.format(problemDate).toString());
127+
TemplateBuffer buffer = fTranslator.translate("Today is ${d:date('yyyy-MM-dd', 'this_invalid_locale')}!");
119128
fType.resolve(buffer, fContext);
120129

121130
StringBuilder expected= new StringBuilder();
122131
expected.append("Today is ");
123132
expected.append(
124-
new SimpleDateFormat("YYYY-MM-dd", new Locale("this_invalid_locale")).format(new java.util.Date()));
133+
new SimpleDateFormat("yyyy-MM-dd", new Locale("this_invalid_locale")).format(new java.util.Date()));
125134
expected.append("!");
126135
assertBufferStringAndVariables(expected.toString(), buffer);
127136
}

0 commit comments

Comments
 (0)