Skip to content

Commit e358cd6

Browse files
committed
Deprecate for removal QuickMenuCreator#dispose
And stop calling it as it is a no-op anyway.
1 parent e738501 commit e358cd6

File tree

4 files changed

+4
-7
lines changed

4 files changed

+4
-7
lines changed

bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/actions/QuickMenuAction.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*******************************************************************************
2-
* Copyright (c) 2004, 2015 IBM Corporation and others.
2+
* Copyright (c) 2004, 2026 IBM Corporation and others.
33
*
44
* This program and the accompanying materials
55
* are made available under the terms of the Eclipse Public License 2.0
@@ -61,7 +61,6 @@ public void run() {
6161
*/
6262
public void dispose() {
6363
if (creator != null) {
64-
creator.dispose();
6564
creator = null;
6665
}
6766
}

bundles/org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/actions/QuickMenuCreator.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -274,7 +274,7 @@ private int getAverageCharWidth(Control control) {
274274
* {@link #createMenu()} will be disposed shortly after the SWT.Hide
275275
* event.
276276
*/
277-
@Deprecated
277+
@Deprecated(forRemoval = true, since = "2026-03")
278278
public void dispose() {
279279
}
280280
}

bundles/org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/internal/actions/ModifyWorkingSetDelegate.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*******************************************************************************
2-
* Copyright (c) 2006, 2015 IBM Corporation and others.
2+
* Copyright (c) 2006, 2026 IBM Corporation and others.
33
*
44
* This program and the accompanying materials
55
* are made available under the terms of the Eclipse Public License 2.0
@@ -164,7 +164,6 @@ public void init(IWorkbenchWindow window) {
164164
public void dispose() {
165165
getWindow().getWorkbench().getWorkingSetManager().removePropertyChangeListener(listener);
166166
super.dispose();
167-
contextMenuCreator.dispose();
168167
}
169168

170169
@Override

bundles/org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/internal/handlers/QuickMenuHandler.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*******************************************************************************
2-
* Copyright (c) 2008, 2015 IBM Corporation and others.
2+
* Copyright (c) 2008, 2026 IBM Corporation and others.
33
*
44
* This program and the accompanying materials
55
* are made available under the terms of the Eclipse Public License 2.0
@@ -65,7 +65,6 @@ public Object execute(ExecutionEvent event) throws ExecutionException {
6565
@Override
6666
public void dispose() {
6767
if (creator != null) {
68-
creator.dispose();
6968
creator = null;
7069
}
7170
}

0 commit comments

Comments
 (0)