Do not show Contribution Item if the Property Tester is not

raghucssit · raghucssit · commit efb40759b8bc · 2025-04-10T17:03:30.000+02:00
instantiated. By default each contribution item is visible when the platform ui is created. Later Menu/Toolbar listeners check with VisibleWhen expression to show/hide the Item. If the bundle containing Property tester is not loaded then the visibility remains true. We can hide the contribution if the property tester is not loaded. See #2900
diff --git a/bundles/org.eclipse.e4.ui.workbench/src/org/eclipse/e4/ui/internal/workbench/ContributionsAnalyzer.java b/bundles/org.eclipse.e4.ui.workbench/src/org/eclipse/e4/ui/internal/workbench/ContributionsAnalyzer.java
@@ -260,7 +260,7 @@ private static boolean isCoreExpressionVisible(MCoreExpression coreExpression, f
 		}
 		boolean ret = false;
 		try {
-			ret = ref.evaluate(eContext) != EvaluationResult.FALSE;
+			ret = ref.evaluate(eContext) == EvaluationResult.TRUE ? true : false;
 		} catch (Exception e) {
 			if (DEBUG) {
 				trace("isVisible exception", e); //$NON-NLS-1$

Original file line number	Diff line number	Diff line change
`@@ -260,7 +260,7 @@ private static boolean isCoreExpressionVisible(MCoreExpression coreExpression, f`
`260`	`260`	`}`
`261`	`261`	`boolean ret = false;`
`262`	`262`	`try {`
`263`		`- ret = ref.evaluate(eContext) != EvaluationResult.FALSE;`
	`263`	`+ ret = ref.evaluate(eContext) == EvaluationResult.TRUE ? true : false;`
`264`	`264`	`} catch (Exception e) {`
`265`	`265`	`if (DEBUG) {`
`266`	`266`	`trace("isVisible exception", e); //$NON-NLS-1$`