Skip to content

Commit f18b3fa

Browse files
committed
[Dark Theme] Fix for highlight issue in sub-tabs
Selected sub-tabs in editor and views were missing blue highlight with the dark theme changes. This has been fixed with this change.
1 parent ca298d6 commit f18b3fa

File tree

4 files changed

+14
-46
lines changed

4 files changed

+14
-46
lines changed

bundles/org.eclipse.ui.themes/css/dark/e4-dark_tabstyle.css

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -37,18 +37,20 @@ CTabFolder {
3737
swt-selected-tab-highlight: none;
3838
}
3939

40-
CTabFolder[style~='SWT.DOWN'][style~='SWT.BOTTOM'] {
40+
.MPartStack CTabFolder[style~='SWT.DOWN'][style~='SWT.BOTTOM'] {
4141
/* Set the styles for the bottom inner tabs (Bug 430051): */
4242
swt-tab-renderer: url('bundleclass://org.eclipse.e4.ui.workbench.renderers.swt/org.eclipse.e4.ui.workbench.renderers.swt.CTabRendering');
43-
swt-unselected-hot-tab-color-background: #161616; /* Bug 465711 */
44-
swt-selected-tab-highlight: #316c9b;
45-
swt-selected-highlight-top: false;
43+
swt-unselected-hot-tab-color-background: #161616;/* Bug 465711 */
44+
swt-selected-tab-highlight: #a6a6a6;
45+
swt-selected-highlight-top: true;
4646
}
4747

48-
49-
CTabFolder.active {
50-
swt-selected-tab-highlight: #316c9b;
51-
swt-selected-highlight-top: false;
48+
.MPartStack.active CTabFolder[style~='SWT.DOWN'][style~='SWT.BOTTOM'] {
49+
/* Set the styles for the bottom inner tabs (Bug 430051): */
50+
swt-tab-renderer: url('bundleclass://org.eclipse.e4.ui.workbench.renderers.swt/org.eclipse.e4.ui.workbench.renderers.swt.CTabRendering');
51+
swt-unselected-hot-tab-color-background: #161616;/* Bug 465711 */
52+
swt-selected-tab-highlight: #2b97d7;
53+
swt-selected-highlight-top: true;
5254
}
5355

5456
CTabItem,

bundles/org.eclipse.ui.themes/css/e4-dark_linux.css

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,6 @@ ImageBasedFrame,
8787

8888
#org-eclipse-ui-editorss CTabFolder{
8989
swt-selected-tab-fill : '#1E1F22';
90-
swt-selected-tab-highlight: '#a6a6a6';
9190
swt-selected-highlight-top: true;
9291
swt-draw-custom-tab-content-background: true;
9392
swt-unselected-hot-tab-color-background:#161616;
@@ -98,19 +97,9 @@ swt-selected-tab-highlight: '#a6a6a6';
9897
swt-selected-highlight-top: true;
9998
}
10099

101-
CTabFolder[style~='SWT.DOWN'][style~='SWT.BOTTOM'] {
102-
/* Set the styles for the bottom inner tabs (Bug 430051): */
103-
swt-tab-renderer: url('bundleclass://org.eclipse.e4.ui.workbench.renderers.swt/org.eclipse.e4.ui.workbench.renderers.swt.CTabRendering');
104-
swt-selected-tab-fill: #1E1F22;
105-
swt-unselected-tabs-color: #48484c;
106-
swt-unselected-hot-tab-color-background: #2f2f2f;
107-
swt-selected-tab-highlight: #2b79d7;
108-
swt-selected-highlight-top: false;
109-
}
110-
111100
.Editor Form Composite,
112101
.Editor Form Composite Tree,
113102
.MPartStack.active .Editor Form Composite Tree
114103
{
115104
background-color: #1E1F22;
116-
}
105+
}

bundles/org.eclipse.ui.themes/css/e4-dark_mac.css

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,6 @@ Button {
7373

7474
#org-eclipse-ui-editorss CTabFolder{
7575
swt-selected-tab-fill : '#1E1F22';
76-
swt-selected-tab-highlight: '#a6a6a6';
7776
swt-selected-highlight-top: true;
7877
swt-draw-custom-tab-content-background: true;
7978
swt-unselected-hot-tab-color-background:#161616;
@@ -84,20 +83,9 @@ Button {
8483
swt-selected-highlight-top: true;
8584
}
8685

87-
CTabFolder[style~='SWT.DOWN'][style~='SWT.BOTTOM'] {
88-
/* Set the styles for the bottom inner tabs (Bug 430051): */
89-
swt-tab-renderer: url('bundleclass://org.eclipse.e4.ui.workbench.renderers.swt/org.eclipse.e4.ui.workbench.renderers.swt.CTabRendering');
90-
swt-selected-tab-fill: #1E1F22;
91-
swt-unselected-tabs-color: #48484c;
92-
swt-unselected-hot-tab-color-background: #2f2f2f;
93-
swt-selected-tab-highlight: #2b79d7;
94-
swt-selected-highlight-top: false;
95-
}
96-
9786
.Editor Form Composite,
9887
.Editor Form Composite Tree,
9988
.MPartStack.active .Editor Form Composite Tree
10089
{
10190
background-color: #1E1F22;
102-
}
103-
91+
}

bundles/org.eclipse.ui.themes/css/e4-dark_win.css

Lines changed: 2 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -155,26 +155,15 @@ ImageBasedFrame,
155155

156156
#org-eclipse-ui-editorss CTabFolder{
157157
swt-selected-tab-fill : '#1E1F22';
158-
swt-selected-tab-highlight: '#a6a6a6';
159158
swt-selected-highlight-top: true;
160159
swt-draw-custom-tab-content-background: true;
161-
swt-unselected-hot-tab-color-background:#161616;
160+
swt-unselected-hot-tab-color-background:#161616;
162161
}
163162

164163
#org-eclipse-ui-editorss CTabFolder.active {
165164
swt-selected-tab-highlight: '#2b79d7';
166165
swt-selected-highlight-top: true;
167-
}
168-
169-
CTabFolder[style~='SWT.DOWN'][style~='SWT.BOTTOM'] {
170-
/* Set the styles for the bottom inner tabs (Bug 430051): */
171-
swt-tab-renderer: url('bundleclass://org.eclipse.e4.ui.workbench.renderers.swt/org.eclipse.e4.ui.workbench.renderers.swt.CTabRendering');
172-
swt-selected-tab-fill: #1E1F22;
173-
swt-unselected-tabs-color: #48484c;
174-
swt-unselected-hot-tab-color-background: #2f2f2f;
175-
swt-selected-tab-highlight: #2b79d7;
176-
swt-selected-highlight-top: false;
177-
}
166+
}
178167

179168
.Editor Form Composite,
180169
.Editor Form Composite Tree,

0 commit comments

Comments
 (0)