Skip to content

Commit fe43009

Browse files
mvm-sapmvm-sap
committed
[Dark Theme] Fix for highlight issue in sub-tabs
Selected sub-tabs in editor and views were missing blue highlight with the dark theme changes. This has been fixed with this change.
1 parent 61cca8f commit fe43009

File tree

3 files changed

+52
-38
lines changed

3 files changed

+52
-38
lines changed

‎bundles/org.eclipse.ui.themes/css/e4-dark_linux.css‎

Lines changed: 17 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -80,14 +80,29 @@ ImageBasedFrame,
8080
swt-selected-highlight-top: false;
8181
}
8282

83+
.MPartStack CTabFolder[style~='SWT.DOWN'][style~='SWT.BOTTOM'] {
84+
/* Set the styles for the bottom inner tabs (Bug 430051): */
85+
swt-tab-renderer: url('bundleclass://org.eclipse.e4.ui.workbench.renderers.swt/org.eclipse.e4.ui.workbench.renderers.swt.CTabRendering');
86+
swt-unselected-hot-tab-color-background: #161616;/* Bug 465711 */
87+
swt-selected-tab-highlight: #a6a6a6;
88+
swt-selected-highlight-top: true;
89+
}
90+
91+
.MPartStack.active CTabFolder[style~='SWT.DOWN'][style~='SWT.BOTTOM'] {
92+
/* Set the styles for the bottom inner tabs (Bug 430051): */
93+
swt-tab-renderer: url('bundleclass://org.eclipse.e4.ui.workbench.renderers.swt/org.eclipse.e4.ui.workbench.renderers.swt.CTabRendering');
94+
swt-unselected-hot-tab-color-background: #161616;/* Bug 465711 */
95+
swt-selected-tab-highlight: #2b97d7;
96+
swt-selected-highlight-top: true;
97+
}
98+
8399
/*text color of selected tab in editor */
84100
#org-eclipse-ui-editorss CTabItem:selected{
85101
color: '#FFFFFF';
86102
}
87103

88104
#org-eclipse-ui-editorss CTabFolder{
89105
swt-selected-tab-fill : '#1E1F22';
90-
swt-selected-tab-highlight: '#a6a6a6';
91106
swt-selected-highlight-top: true;
92107
swt-draw-custom-tab-content-background: true;
93108
swt-unselected-hot-tab-color-background:#161616;
@@ -98,19 +113,9 @@ swt-selected-tab-highlight: '#a6a6a6';
98113
swt-selected-highlight-top: true;
99114
}
100115

101-
CTabFolder[style~='SWT.DOWN'][style~='SWT.BOTTOM'] {
102-
/* Set the styles for the bottom inner tabs (Bug 430051): */
103-
swt-tab-renderer: url('bundleclass://org.eclipse.e4.ui.workbench.renderers.swt/org.eclipse.e4.ui.workbench.renderers.swt.CTabRendering');
104-
swt-selected-tab-fill: #1E1F22;
105-
swt-unselected-tabs-color: #48484c;
106-
swt-unselected-hot-tab-color-background: #2f2f2f;
107-
swt-selected-tab-highlight: #2b79d7;
108-
swt-selected-highlight-top: false;
109-
}
110-
111116
.Editor Form Composite,
112117
.Editor Form Composite Tree,
113118
.MPartStack.active .Editor Form Composite Tree
114119
{
115120
background-color: #1E1F22;
116-
}
121+
}

‎bundles/org.eclipse.ui.themes/css/e4-dark_mac.css‎

Lines changed: 17 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -66,14 +66,29 @@ Button {
6666
swt-selected-highlight-top: false;
6767
}
6868

69+
.MPartStack CTabFolder[style~='SWT.DOWN'][style~='SWT.BOTTOM'] {
70+
/* Set the styles for the bottom inner tabs (Bug 430051): */
71+
swt-tab-renderer: url('bundleclass://org.eclipse.e4.ui.workbench.renderers.swt/org.eclipse.e4.ui.workbench.renderers.swt.CTabRendering');
72+
swt-unselected-hot-tab-color-background: #161616;/* Bug 465711 */
73+
swt-selected-tab-highlight: #a6a6a6;
74+
swt-selected-highlight-top: true;
75+
}
76+
77+
.MPartStack.active CTabFolder[style~='SWT.DOWN'][style~='SWT.BOTTOM'] {
78+
/* Set the styles for the bottom inner tabs (Bug 430051): */
79+
swt-tab-renderer: url('bundleclass://org.eclipse.e4.ui.workbench.renderers.swt/org.eclipse.e4.ui.workbench.renderers.swt.CTabRendering');
80+
swt-unselected-hot-tab-color-background: #161616;/* Bug 465711 */
81+
swt-selected-tab-highlight: #2b97d7;
82+
swt-selected-highlight-top: true;
83+
}
84+
6985
/*text color of selected tab in editor */
7086
#org-eclipse-ui-editorss CTabItem:selected{
7187
color: '#FFFFFF';
7288
}
7389

7490
#org-eclipse-ui-editorss CTabFolder{
7591
swt-selected-tab-fill : '#1E1F22';
76-
swt-selected-tab-highlight: '#a6a6a6';
7792
swt-selected-highlight-top: true;
7893
swt-draw-custom-tab-content-background: true;
7994
swt-unselected-hot-tab-color-background:#161616;
@@ -84,20 +99,9 @@ Button {
8499
swt-selected-highlight-top: true;
85100
}
86101

87-
CTabFolder[style~='SWT.DOWN'][style~='SWT.BOTTOM'] {
88-
/* Set the styles for the bottom inner tabs (Bug 430051): */
89-
swt-tab-renderer: url('bundleclass://org.eclipse.e4.ui.workbench.renderers.swt/org.eclipse.e4.ui.workbench.renderers.swt.CTabRendering');
90-
swt-selected-tab-fill: #1E1F22;
91-
swt-unselected-tabs-color: #48484c;
92-
swt-unselected-hot-tab-color-background: #2f2f2f;
93-
swt-selected-tab-highlight: #2b79d7;
94-
swt-selected-highlight-top: false;
95-
}
96-
97102
.Editor Form Composite,
98103
.Editor Form Composite Tree,
99104
.MPartStack.active .Editor Form Composite Tree
100105
{
101106
background-color: #1E1F22;
102-
}
103-
107+
}

‎bundles/org.eclipse.ui.themes/css/e4-dark_win.css‎

Lines changed: 18 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -148,33 +148,38 @@ ImageBasedFrame,
148148
swt-selected-highlight-top: false;
149149
}
150150

151+
.MPartStack CTabFolder[style~='SWT.DOWN'][style~='SWT.BOTTOM'] {
152+
/* Set the styles for the bottom inner tabs (Bug 430051): */
153+
swt-tab-renderer: url('bundleclass://org.eclipse.e4.ui.workbench.renderers.swt/org.eclipse.e4.ui.workbench.renderers.swt.CTabRendering');
154+
swt-unselected-hot-tab-color-background: #161616;/* Bug 465711 */
155+
swt-selected-tab-highlight: #a6a6a6;
156+
swt-selected-highlight-top: true;
157+
}
158+
159+
.MPartStack.active CTabFolder[style~='SWT.DOWN'][style~='SWT.BOTTOM'] {
160+
/* Set the styles for the bottom inner tabs (Bug 430051): */
161+
swt-tab-renderer: url('bundleclass://org.eclipse.e4.ui.workbench.renderers.swt/org.eclipse.e4.ui.workbench.renderers.swt.CTabRendering');
162+
swt-unselected-hot-tab-color-background: #161616;/* Bug 465711 */
163+
swt-selected-tab-highlight: #2b97d7;
164+
swt-selected-highlight-top: true;
165+
}
166+
151167
/*text color of selected tab in editor */
152168
#org-eclipse-ui-editorss CTabItem:selected{
153169
color: '#FFFFFF';
154170
}
155171

156172
#org-eclipse-ui-editorss CTabFolder{
157173
swt-selected-tab-fill : '#1E1F22';
158-
swt-selected-tab-highlight: '#a6a6a6';
159174
swt-selected-highlight-top: true;
160175
swt-draw-custom-tab-content-background: true;
161-
swt-unselected-hot-tab-color-background:#161616;
176+
swt-unselected-hot-tab-color-background:#161616;
162177
}
163178

164179
#org-eclipse-ui-editorss CTabFolder.active {
165180
swt-selected-tab-highlight: '#2b79d7';
166181
swt-selected-highlight-top: true;
167-
}
168-
169-
CTabFolder[style~='SWT.DOWN'][style~='SWT.BOTTOM'] {
170-
/* Set the styles for the bottom inner tabs (Bug 430051): */
171-
swt-tab-renderer: url('bundleclass://org.eclipse.e4.ui.workbench.renderers.swt/org.eclipse.e4.ui.workbench.renderers.swt.CTabRendering');
172-
swt-selected-tab-fill: #1E1F22;
173-
swt-unselected-tabs-color: #48484c;
174-
swt-unselected-hot-tab-color-background: #2f2f2f;
175-
swt-selected-tab-highlight: #2b79d7;
176-
swt-selected-highlight-top: false;
177-
}
182+
}
178183

179184
.Editor Form Composite,
180185
.Editor Form Composite Tree,

0 commit comments

Comments
 (0)