Restore original Problems view sort order for severity and priority

Regression from f13fb49.

One part of the regression was already fixed via
935b1db (in `QuickFixPage`).

This change fixes remaining regressions that affect sort order of
markers where severity and priority attributes are involved.

Markers with higher values of severity/priority should be always sorted
first by default (the opposite to the "natural" sort order), because we
want that the *most important* markers are shown to the user by default
(without scrolling and filtering).

Fixes #2845

Author: iloveeclipse

bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/views/markers/MarkerPriorityField.java

@@ -100,8 +100,10 @@ public MarkerPriorityField() {
 
 	@Override
 	public int compare(MarkerItem item1, MarkerItem item2) {
-		return Integer.compare(item1.getAttributeValue(IMarker.PRIORITY, IMarker.PRIORITY_NORMAL),
-				item2.getAttributeValue(IMarker.PRIORITY, IMarker.PRIORITY_NORMAL));
+		// Higher values of priority have higher importance and should be sorted first,
+		// so we invert comparison order for priority
+		return Integer.compare(item2.getAttributeValue(IMarker.PRIORITY, IMarker.PRIORITY_NORMAL),
+				item1.getAttributeValue(IMarker.PRIORITY, IMarker.PRIORITY_NORMAL));
 	}
 
 	@Override

bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/views/markers/MarkerProblemSeverityAndMessageField.java

@@ -31,8 +31,10 @@ public class MarkerProblemSeverityAndMessageField extends
 
 	@Override
 	public int compare(MarkerItem item1, MarkerItem item2) {
-		int c = Integer.compare(MarkerSupportInternalUtilities.getSeverity(item1),
-				MarkerSupportInternalUtilities.getSeverity(item2));
+		// Higher values of severity have higher importance and should be sorted first,
+		// so we invert comparison order for severity
+		int c = Integer.compare(MarkerSupportInternalUtilities.getSeverity(item2),
+				MarkerSupportInternalUtilities.getSeverity(item1));
 		if (c != 0) {
 			return c;
 		}

bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/views/markers/MarkerSeverityAndDescriptionField.java

@@ -35,8 +35,10 @@ public MarkerSeverityAndDescriptionField() {
 
 	@Override
 	public int compare(MarkerItem item1, MarkerItem item2) {
-		int c = Integer.compare(MarkerSupportInternalUtilities.getSeverity(item1),
-				MarkerSupportInternalUtilities.getSeverity(item2));
+		// Higher values of severity have higher importance and should be sorted first,
+		// so we invert comparison order for severity
+		int c = Integer.compare(MarkerSupportInternalUtilities.getSeverity(item2),
+				MarkerSupportInternalUtilities.getSeverity(item1));
 		if (c != 0) {
 			return c;
 		}

bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/views/markers/MarkerSeverityField.java

@@ -46,7 +46,9 @@ public String getValue(MarkerItem item) {
 
 	@Override
 	public int compare(MarkerItem item1, MarkerItem item2) {
-		return Integer.compare(MarkerSupportInternalUtilities.getSeverity(item1),
-				MarkerSupportInternalUtilities.getSeverity(item2));
+		// Higher values of severity have higher importance and should be sorted first,
+		// so we invert comparison order for severity
+		return Integer.compare(MarkerSupportInternalUtilities.getSeverity(item2),
+				MarkerSupportInternalUtilities.getSeverity(item1));
 	}
 }