modern light theme: editor right bar to bright

[jukzi]

Only the editor content should have white background, but now also the bar right to the scroll bar has white contrast.

old scheme had had it grey:

[BeckerWdf]

see #2144
for this.
Maybe you can help @mvm-sap with your knowledge to fix the remaining issues in that PR.

[jukzi]

Maybe you can help @mvm-sap with your knowledge to fix the remaining issues in that PR.

Sorry i have no knowledge about how to use themes at all. All i remember is that i did consider the css enginge broken when i looked into it years ago as it did not consider subclasses to match super classes and would suggest to fix that before working with it. Also i would expect that the Layout Spy (shift-ctrl-alt-f9) shows which css classes an element does adhere to. But i can't see helpful information there. Maybe improve that tool first?

[jukzi]

with css spy fixed (eclipse-pde/eclipse.pde#1381) one can see this in the css spy (old light theme):

and with preview light theme:

[jukzi]

i.e. this CSS entry did the coloring:

CTabFolder Canvas {
	background-color: #F8F8F8;
}

eclipse.platform.ui/bundles/org.eclipse.ui.themes/css/e4_default_win.css

Line 74 in b06fb47

CTabFolder Canvas {

Adding that to e4_preview_win.css solves this problem - but i don't know what else it will color too.

[BeckerWdf]

i.e. this CSS entry did the coloring:

CTabFolder Canvas {
	background-color: #F8F8F8;
}

eclipse.platform.ui/bundles/org.eclipse.ui.themes/css/e4_default_win.css

Line 74 in b06fb47

CTabFolder Canvas {

Adding that to e4_preview_win.css solves this problem - but i don't know what else it will color too.

@mvm-sap: Can you pls. have a look at this?

[mvm-sap]

This change will not cause problems in other places. I shall create a PR soon for this.

[mvm-sap]

This issue could be closed as the issue is resolved

[BeckerWdf]

@jukzi: Can you pls verify and close?

[jukzi]

seems to be fixed: