[Find/Replace] Overlay remains active when a dialog is opened

[ptziegler]

Let's make sure issue is not already fixed in latest builds first.

• I verified I can reproduce this issue against latest Integration Build of Eclipse SDK

Steps to reproduce

Open a dialog while the find/replace overlay is active.

Tested under this environment:

• OS & version: Kubuntu 24.04
• Eclipse IDE/Platform version 4.34

Community

• I understand reporting an issue to this OSS project does not mandate anyone to fix it. Other contributors may consider the issue, or not, at their own convenience. The most efficient way to get it fixed is that I fix it myself and contribute it back as a good quality patch to the project.

[deepika-u]

@ptziegler: I am able to see the problem but in a slightly different way. Though the dialog is open, overlay is still seen as highlighted but i cant work in that. Are you able to operate on the overlay? or its just the highlight?

[ptziegler]

If I click on the text field, i see the caret, but I can't actually type anything. The buttons also aren't responsive, so it's primarily the highlight that's problematic.

[Wittmaxi]

likely fixed by #2254

[HeikoKlare]

The reason is that the overlay is an additional top-level shell that is not affected by opening dialogs in the workbench shell. Keeping the overlay open is, in my opinion, expected behavior, but it should be "disabled" like the rest of the UI. On Linux/GTK, this would mean that it is also greyed out.

likely fixed by #2254

Indeed, best solution for this would be to have the overlay not implemented as a separate shell.