Find/Replace Overlay: overlay is stuck sometimes when resizing panes

[Wittmaxi]

possible regression after #2253
@HeikoKlare what do you think?

[HeikoKlare]

For me, this behavior came up after a recent Windows update. I see no difference in this behavior when reverting #2253. Should implicitly be fixed by #2254.

[Wittmaxi]

@HeikoKlare I remember having issues without the PaintListener, which is why I suspected a regression. Let's anyway wait for #2254, otherwise we might be re-doing work

[HeikoKlare]

The reason for this behavior is that the placement update is performed asynchronously, as required by GTK:

eclipse.platform.ui/bundles/org.eclipse.ui.workbench.texteditor/src/org/eclipse/ui/internal/findandreplace/overlay/FindReplaceOverlay.java

Lines 198 to 199 in 1eead54

	private ControlListener targetMovementListener = ControlListener
	.controlResizedAdapter(__ -> asyncExecIfOpen(FindReplaceOverlay.this::updatePlacementAndVisibility));

Making the execution synchronous leads to just-in-time updates of the replacement. We could limit the asynchronous execution to only be performed on GTK, but I am not sure whether the slight improvement for Windows and MacOS is worth an OS-specific implementation.

[nandkishorv18]

Find/Replace overlay behavior is unacceptable, same issue i am facing latest version, i am unable to move anywhere, and seen overlay is not stable when i search anything, for details this video
Screencast from 2024-11-27 20-14-01.webm

Screencast.from.2024-11-27.20-14-01.webm

[merks]

@nandkishorv18

That looks annoying.

I expect the coming release will be better. You can preview it here:

https://www.eclipse.org/downloads/packages/release/2024-12/rc1

Note that can switch back to using the old dialog:

[nandkishorv18]

it has resolved using above option but i will try to upgrade latest version. thank you for instantly support

Thank you @merks

one more question?

how to upgrade this same eclipse to latest version in ubuntu? please suggest step by step,

[HeikoKlare]

Find/Replace overlay behavior is unacceptable, same issue i am facing latest version, i am unable to move anywhere, and seen overlay is not stable when i search anything, for details this video Screencast from 2024-11-27 20-14-01.webm

That issue is unrelated to the initially reported issue in this thread. The same issue has been reported here:

• New find/replace overlay broken under wayland eclipse.platform.swt#1447

And as mentioned by Ed, this will be fixed with the 2024-12 release.

[merks]

Add https://download.eclipse.org/releases/2024-12/ to the preferences

Then use menbar Help -> Check for Updates

That will update to RC1 (release candidate 1) of the 2024-12 release. After Dec 4th, Check for Updates will update to the release.

[nandkishorv18]

@merks thank you for supporting me

[jukzi]

Should implicitly be fixed by #2254.

Can this issue be closed?

[HeikoKlare]

From my understanding, the initially reported behavior comes from Windows and is by intention, as anything else would require rather frequent repaint operations. To me, the behavior does not appear to be an issue either.

The other issue mentioned in the thread is unrelated to the original one and has already been fixed some time ago as well.

Thus closing.