New Wizard Dialog should also include Categories into Filter

[vogella]

If I search in the new project wizard for a category nothing is shown:

I would expect that all entries in the category are shown.

cc @ptziegler as he recently looked at the FilteredTree implementation.

[jukzi]

+1, same for "Show View" Dialog:

[ptziegler]

Based on a quick glance, I believe that this is a very old regression, rather than an enhancement, because in the original implementation, this used to work:

eclipse.platform.ui/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/dialogs/ViewPatternFilter.java

Lines 42 to 78 in c782ba3

	public boolean select(Viewer viewer, Object parentElement, Object element) {
	ITreeContentProvider contentProvider = (ITreeContentProvider) ((TreeViewer) viewer)
	.getContentProvider();
	String text = null;
	Object[] children = null;
	if (element instanceof IViewCategory) {
	IViewCategory desc = (IViewCategory) element;
	children = contentProvider.getChildren(desc);
	text = desc.getLabel();
	} else if (element instanceof IViewDescriptor) {
	IViewDescriptor desc = (IViewDescriptor) element;
	children = contentProvider.getChildren(desc);
	text = desc.getLabel();
	}
	if (wordMatches(text)){
	// make sure the category has at least one matching child
	// to prevent an empty caategory from appearing
	if (element instanceof IViewCategory && children != null){
	for (int i = 0; i < children.length; i++){
	if (select(viewer, element, children[i]))
	return true;
	}
	return false; // no matching children
	}
	return true;
	}
	if (matchItem && children != null) {
	// Will return true if any subnode of the element matches the search
	if (filter(viewer, element, children).length > 0)
	return true;
	}
	return false;
	}

But then broke as part of 7275893

In principle, it should be sufficient to simply override ìsParentMatch(...), because the default implementation is not the desired behavior:

Check if the parent (category) is a match to the filter text. The defaultbehavior returns true if the element has at least one child element that is amatch with the filter text.Subclasses may override this method.

I can have a look later but at least it apears to be a trivial change...

[vogella]

I can have a look later but at least it apears to be a trivial change...

Awesome, thanks @ptziegler

[vogella]

The fix does not work for me in:

Eclipse SDK
Version: 2025-03 (4.35)
Build id: I20241208-1800
OS: Linux, v.6.8.0-49-generic, x86_64 / gtk 3.24.41
Java vendor: Ubuntu
Java runtime version: 21.0.5+11-Ubuntu-1ubuntu124.04
Java version: 21.0.5

[ptziegler]

The "New" wizard has its own pattern filter that also needs to be adapted.

[vogella]

I assume the same for the Show View dialog (in which filtering by category is also not working)? Could you also provide PR for these two dialogs @ptziegler?