Skip to content

Show source on hover & Declaration view broken #2600

@iloveeclipse

Description

@iloveeclipse

Just discovered that the change #2051 also (additionally to eclipse-jdt/eclipse.jdt.ui#1843) broke source hover functionality in Java editor (Shift + Hover over method to see implementation).

Stack:

java.lang.NullPointerException
	at java.base/java.util.Objects.requireNonNull(Objects.java:233)
	at java.base/java.util.Arrays$ArrayList.<init>(Arrays.java:4238)
	at java.base/java.util.Arrays.asList(Arrays.java:4223)
	at org.eclipse.jface.text.source.SourceViewer.configure(SourceViewer.java:550)
	at org.eclipse.jdt.internal.ui.javaeditor.JavaSourceViewer.configure(JavaSourceViewer.java:224)
	at org.eclipse.jdt.internal.ui.text.java.hover.SourceViewerInformationControl.<init>(SourceViewerInformationControl.java:219)
	at org.eclipse.jdt.internal.ui.text.java.hover.JavaSourceHover$1.<init>(JavaSourceHover.java:888)
	at org.eclipse.jdt.internal.ui.text.java.hover.JavaSourceHover.createControl(JavaSourceHover.java:888)
	at org.eclipse.jdt.internal.ui.text.java.hover.JavaSourceHover.lambda$3(JavaSourceHover.java:883)
	at org.eclipse.jface.text.AbstractInformationControlManager.getInformationControl(AbstractInformationControlManager.java:829)
	at org.eclipse.jface.text.AbstractInformationControlManager.internalShowInformationControl(AbstractInformationControlManager.java:1138)
	at org.eclipse.jface.text.AbstractInformationControlManager.presentInformation(AbstractInformationControlManager.java:1120)
	at org.eclipse.jface.text.AbstractHoverInformationControlManager.presentInformation(AbstractHoverInformationControlManager.java:884)
	at org.eclipse.jface.text.TextViewerHoverManager.doPresentInformation(TextViewerHoverManager.java:237)
	at org.eclipse.jface.text.TextViewerHoverManager.lambda$3(TextViewerHoverManager.java:227)
	at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:40)
	at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:132)
	at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:5042)

This is a severe regression, @lathapatil : please provide a fix ASAP.
Also please consider to fix review comments from @szarnekow.

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions