FindReplaceOverlay/FindReplaceDialog: correcting regexp does not work

[jukzi]

#2655 (comment)

having a java:

package a;

public class A {
public static void main(String[] args) {
	
}
public static void main2(String[] args) {
	
}
public static void main3(String[] args) {
	
}
}

1. open search overlay
2. enable regexp
3. enter "main"
4. press Search forward button
5. enter "main\n" in Replace Dialog
6. press Replace button -> does not work because of wrong line break (unituitive)
7. enter "main\r\n" in Replace Dialog
8. press Replace button -> still does not work WHY?

[HeikoKlare]

I can confirm this issue. It is properly reproducibly with the given example workflow.

I can add that this issue has likely been there forever. It is reproducible in, e.g., a 2023-12 release and also a 2020-03 release (the latter with even more issues). Here you can see the same issue in the 2023-12 release:

The issue is rooted in the FindReplaceDocumentAdapter (or how its consumers use it). FindReplaceDocumentAdapter#findReplace(...) leaves an consistent state when not finishing successfully. This implementation and its consumers have not been changed for almost 20 years.
In my opinion, the produced state of that method should be considered incorrect (in contrast to requiring consumers to handle this behavior). I will provide an according fix proposal.

[HeikoKlare]

Fixed by #2664 (not auto-closed as convention was not met accidentally).