Find/Replace overlay can't be disabled by product customization

[iloveeclipse]

While moving to 4.35 we've found issues with Find/replace overlay and custom multi page editors.
We are investigating whether is that a problem on our side or in the platform, and in the meantime we wanted to disable Find/Replace overlay by default via product customization. To my surprise that failed :-(

The preferences dialog shows expected value, but the code that decides whether to use Find/Replace or not (and at which position) is broken, as it only considers the instance (workspace) settings and not product/configuration settings. This is unfortunately a common mistake...

I will push a patch in a moment.

[HeikoKlare]

Thank you for the catch and for fixing it, @iloveeclipse @jukzi!

Regarding the multi-page editors: they have been quite a problem for the find/replace overlay all the time. The issues so far were usually related to the (de)activation of editor actions, e.g.:

• Find/replace overlay: allow pasting in multi-page editors #2509 #2516
• Avoid FindReplaceOverlay setTextEditorActionsActivated resulting in NPE #2724

If you have a reproducer for further issues, I will try to have a look.

[iloveeclipse]

@HeikoKlare : I believe we need #2724, because we've started with a nightly build a day or two before, and I've not updated the platform build yet, waiting for M3. We have another issue found, but not clear yet if that is the result of #2724 too.
I will update our build next week after M3, we will see.

[iloveeclipse]

Update: I believe we need #2516 too :-)

[iloveeclipse]

Actually #2516 is already there. So we have yet another variant of that...