The code mining does not reset line vertical indentation when editor auto inserts multiple lines of code

[jdneo]

Let's make sure issue is not already fixed in latest builds first.

• I verified I can reproduce this issue against latest Integration Build of Eclipse SDK

Context

I'm working on Eclipse copilot plugin, the plugin leverage code mining to display the inline completions.

Steps to reproduce

1. Above a java method, type /**
2. Code mining appear
3. Press Enter (At this point the plugin will clear the code mining provider, and request editor to update code mining)
4. Because it's start with /**, editor will insert multiple lines of code to complete the javadoc template
5. The line vertical indentation is not reset correctly.

Screen.Recording.2025-07-23.at.10.57.40.mov

Is it because the editor inserts multiple lines, making the code mining resets the indentation at a wrong row index?

Community

• I understand reporting an issue to this OSS project does not mandate anyone to fix it. Other contributors may consider the issue, or not, at their own convenience. The most efficient way to get it fixed is that I fix it myself and contribute it back as a good quality patch to the project.

[laeubi]

FYI @tobiasmelcher as you previously worked on line-heights here

• Fix replaceTextRange logic for unfocused StyledText with variable line height eclipse.platform.swt#2318

[mickaelistria]

Thanks for the report. Do you think you could create a minimal reproducer in a demo or even a unit test?
See https://github.com/eclipse-platform/eclipse.platform.ui/blob/master/examples/org.eclipse.jface.text.examples/src/org/eclipse/jface/text/examples/codemining/CodeMiningDemo.java for or https://github.com/eclipse-platform/eclipse.platform.ui/blob/master/tests/org.eclipse.jface.text.tests/src/org/eclipse/jface/text/tests/codemining/CodeMiningTest.java for instance ?

[BeckerWdf]

FYI @tobiasmelcher as you previously worked on line-heights here

• Fix replaceTextRange logic for unfocused StyledText with variable line height eclipse.platform.swt#2318

He currently is on vacation. So it might take some time until he can have a look at it. Pls. be patient.

[tobiasmelcher]

Thanks a lot for reporting this issue.
@jdneo could you please do me a favor and change your code in a way so that SourceViewer#updateCodeMinings is called in the main thread. I'll ask you to change your implementation of com.microsoft.copilot.eclipse.ui.completion.CompletionManager.updateCodeMinings to something like this

Display.getDefault().asyncExec(new Runnable() {
  @Override
  public void run() {
    sourceViewer.updateCodeMinings();
  }
}

Does the problem then still occur?

[jdneo]

Hi @tobiasmelcher,

it still occurs after this change.

I'll try to make a reproduceble project this week.

[tobiasmelcher]

Hi @jdneo ,
thanks a lot for the fast response and update. I didn't expect it. You are running on Mac, correct?

Could you please apply following patch in file org.eclipse.jface.text/src/org/eclipse/jface/internal/text/codemining/CodeMiningManager.java by importing the org.eclipse.jface.text plugin as source code to your local dev workspace? On my machine under windows, problem then disappears. Is this also the case on your machine?

diff --git a/bundles/org.eclipse.jface.text/src/org/eclipse/jface/internal/text/codemining/CodeMiningManager.java b/bundles/org.eclipse.jface.text/src/org/eclipse/jface/internal/text/codemining/CodeMiningManager.java
index 9a09905..d213622 100644
--- a/bundles/org.eclipse.jface.text/src/org/eclipse/jface/internal/text/codemining/CodeMiningManager.java
+++ b/bundles/org.eclipse.jface.text/src/org/eclipse/jface/internal/text/codemining/CodeMiningManager.java
@@ -31,6 +31,7 @@
 
 import org.eclipse.swt.events.MouseEvent;
 import org.eclipse.swt.graphics.Rectangle;
+import org.eclipse.swt.widgets.Display;
 
 import org.eclipse.core.runtime.Assert;
 import org.eclipse.core.runtime.ILog;
@@ -292,9 +293,15 @@
 		});
 		// check if request was canceled.
 		monitor.isCanceled();
-		fInlinedAnnotationSupport.updateAnnotations(currentAnnotations);
-		// redraw the existing codemining annotations since their content can change
-		annotationsToRedraw.stream().forEach(ICodeMiningAnnotation::redraw);
+		Display.getDefault().asyncExec(new Runnable() {
+
+			@Override
+			public void run() {
+				fInlinedAnnotationSupport.updateAnnotations(currentAnnotations);
+				// redraw the existing codemining annotations since their content can change
+				annotationsToRedraw.stream().forEach(ICodeMiningAnnotation::redraw);
+			}
+		});
 	}
 
 	/**

I have some doubts if this change is compatible with all scenarios. Let's see if it works also on your machine. In case of success, I will then upload a pull request and raise a discussion with the eclipse community.

Thanks again and best regards,
Tobias

[jdneo]

Hi @tobiasmelcher,

The patch will solve the issue somehow, but it has a problem. The inline completion will not be rendered for the first time. Even when I keep triggering it, it will not be displayed.

Screen.Recording.2025-08-08.at.13.42.47.mov

If you see the video carefully, you can see that there is a sudden that the code mining is rendered after I typed /**, then it disappears (before 0:02 in the video). After that, I triggered the inline completion multiple times. Each time, it will call sourceViewer.updateCodeMinings();, but the code mining is not rendered.

Only one way to make the code mining appear again is that:

1. Click ESC (This will clear the code minings from code mining provider)
2. Re-trigger it again.

Screen.Recording.2025-08-08.at.13.46.46.mov

[tobiasmelcher]

Hi @jdneo,

thanks a lot for the feedback. I am very sorry, but I cannot reproduce this behavior on my machine.
Could you please provide a detailed description step-by-step how to reproduce the problem scenario?
Could you please test the behavior in your target IDE without the modification done in CodeMiningManager (but including the imported org.eclipse.jface.text plugin in your workspace)? Maybe, you have an inconsistent setup where the org.eclipse.jface.text Plugin doesn't fit/match to the target IDE installation?

With best regards,
Tobias

[jdneo]

Thank you, I'll do some more checks later. And provide a reproducible code when possible

[tobiasmelcher]

@jdneo, I think I found a solution with #3170 . Could you please help with testing the fix? Does it also solve the problem on your machine?

[jdneo]

Thank you @tobiasmelcher, tried with the change several times and the problem does not appear anymore.

[tobiasmelcher]

Great news, thanks a lot @jdneo for testing the fix.