Window size is overwritten when maximized [Regression]

[wahlbrink]

The window size saved in the model is overwritten when the user maximizes the window.

This is a regression introduced by #3055

The change wrongly removed the return after it sets the ShellMaximizedTag.

Steps to reproduce

• Resize the window
• Maximize the window
• Restart -> the size is lost

Tested under this environment:

Version: 2025-09 (4.37)
Build id: I20250827-0600
Windows 11

[wahlbrink]

The current code does not match the code comment: Don't store the maximized size in the model

IMHO the code at https://github.com/eclipse-platform/eclipse.platform.ui/blob/master/bundles/org.eclipse.e4.ui.workbench.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/WBWRenderer.java#L535 should looks like:

				public void controlResized(ControlEvent e) {
					// Don't store the maximized size in the model
					// But set the maximized tag so that the user can access the current state
					if (shell.getMaximized()) {
						me.getTags().add(ShellMaximizedTag);
						return;
					}
					me.getTags().remove(ShellMaximizedTag);

[laeubi]

@wahlbrink do you like to suggest a PR?

[iloveeclipse]

@wahlbrink : the ticket description is very technical and doesn't say me what is the actual problem user will observe?
Can you also provide steps to reproduce the problem?

[iloveeclipse]

Note: I've followed the steps in the description, but I don't see any issue, after restart of maximized window it is still maximized. So something is missing in the steps?

[merks]

Just guess. If you restore the maximized window after the restart, does it have the expected size, i.e., the size that it had before it was maximized?

[laeubi]

Note: I've followed the steps in the description, but I don't see any issue, after restart of maximized window it is still maximized. So something is missing in the steps?

@iloveeclipse the problem should be visible when you restore the window. So lets assume the following:

1. You have carefully set the size of your IDE to a certain size, e.g. 800x600px on a larger screen
2. Now you maximize the Workbench, then restore it again and get back to 800x600px

If you now in step 2 restart the workbench in between the previous 800x600px is overwritten with whatever your screen-size is and restoring it will not really bring it back to a smaller size.

[merks]

If I follow the steps, the window is restored not maximized, at the location it was before it was maximized but with the size it has while maximized. That's kind of horrible too.

[iloveeclipse]

1. Set some special window size
2. Maximize window
3. Restart workbench
4. Window is started maximized (OK)
5. "Restore" window - now some other (no idea which one) window size is used.

Did I understood this right?

[laeubi]

Did I understood this right?

Yes.

[iloveeclipse]

But with the fix I see another bug: the previously maximized window is restarted with the "special" size. So neither the original fix nor the fix for the fix are working as expected.

With #3228 I see following:

1. Set some special window size
2. Maximize window
3. Restart workbench
4. Window size matches the "special" one set in step 1, window is NOT started maximized (bug)