[Dark Theme] Checkbox created with toolkit on dialog has wrong background

[marcushoepfner]

A button with SWT.CHECK gets a wrong background color (light grey instead of dark grey) under the following conditions:

• created on a dialog
• toolkit used (FormToolkit.createButton)
• darktheme

In an editor this does not happen.

Does happen on Mac. Not on Windows.

[akurtakov]

Can you share the snippet to reproduce?

[marcushoepfner]

sure.
background.test_1.0.0.202210171431.zip

(It's actually a jar, but github does not support. You might need to rename back to .jar)

[marcushoepfner]

I have started analyzing this:

• FormToolkit calls adapt() when creating the checkbox; a background color is set
• afterwards the css engine overwrites this background color via Control.setBackground(Color color) with null
• this leads to the light grey eventually

Compared to e.g. a label created with toolkit

• FormToolkit calls adapt() when creating the label; a background color is set
• afterwards the css engine overwrites this background color via Control.setBackground(Color color) with a concrete color

Is just the color in css missing?

[marcushoepfner]

Does someone has a hint how to fix this? If so, I can take over and try.

[akurtakov]

Can you share the code for this jar so it can be used for debugging?

[marcushoepfner]

Oh damn. I forgot. Thanks for bearing with me.
Here it is, same disclaimer: rename from zip to jar
background.test.source_1.0.0.202210191250.zip

[marcushoepfner]

Hi, any progress on this one?

[akurtakov]

Unfortunately not many people look into MacOS specific issues (@Phillipus only lately) . In my opinion this could be SWT bug but it could be css styling issue too. In order to get this issue moving people with interest (and access) in MacOS have to step up but you can further help by trying to reduce the snippet to pure SWT snippet one .

[Phillipus]

not sure whether it happens on Windows.

OK on Windows:

reduce the snippet to pure SWT snippet one .

Not sure if that's possible as it depends on dark theme and Theming framework.

@marcushoepfner Perhaps you might investigate the dark *.css files in the theme plug-in to see if any change required there?

[BeckerWdf]

I even see issues in the light theme on macOS:

[marcushoepfner]

Better Checkbox Coloring on Dialog when using FormToolkit #2474

Correct. I've seen this as well. There is also an issue with light theme.

[BeckerWdf]

I even see issues in the light theme on macOS:

It looks the same when theming is "turned off" in the preferences. The widget should always look correct also when theming is off. So fixing this via CSS feels wrong to me.