Modify the 'Close Active Editors' (plural) handler to add support for… #2360
Conversation
|
Can you please add a junit test? referenced issue: #2176 |
@jukzi Certainly I can try - would there any pre-existing tests in the area of editor opening/closing (ideally compatibility layer plus E4 part descriptor fragment contribution) that you could point me towards as a starting point of reference? |
|
sorry i am not familiar with e4, but you may look around in |
|
@jukzi JUnit test added now, hopefully it is sufficient for what needs to be covered |
tests/org.eclipse.ui.tests/Eclipse UI Tests/org/eclipse/ui/tests/e4/CloseAllHandlerTest.java
Outdated
Show resolved
Hide resolved
tests/org.eclipse.ui.tests/Eclipse UI Tests/org/eclipse/ui/tests/e4/CloseAllHandlerTest.java
Show resolved
Hide resolved
tests/org.eclipse.ui.tests/Eclipse UI Tests/org/eclipse/ui/tests/e4/DummyEditor.java
Outdated
Show resolved
Hide resolved
tests/org.eclipse.ui.tests/Eclipse UI Tests/org/eclipse/ui/tests/e4/DummyEditor.java
Outdated
Show resolved
Hide resolved
.../org.eclipse.e4.ui.tests/src/org/eclipse/e4/ui/tests/application/CloseActiveEditorsTest.java
Outdated
Show resolved
Hide resolved
.../org.eclipse.e4.ui.tests/src/org/eclipse/e4/ui/tests/application/CloseActiveEditorsTest.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/CloseAllHandler.java
Outdated
Show resolved
Hide resolved
tests/org.eclipse.ui.tests/Eclipse UI Tests/org/eclipse/ui/tests/e4/CloseAllHandlerTest.java
Outdated
Show resolved
Hide resolved
jukzi
left a comment
jukzi
left a comment
There was a problem hiding this comment.
some minor code style issues only
|
Code style & copyright block changes applied, hopefully I caught everything there. |
jukzi
left a comment
jukzi
left a comment
There was a problem hiding this comment.
LGTM, lets wait a bit if someone else wants to review / test
… parts which represent an Editor and are contributed via eg. PartDescriptors in a Model Fragment. Associated with Issue#2176. Include JUnit test.
feilimb
force-pushed
the
close_all_editors_e4_contribs
branch
from
5306d26 to
0174c8f
Compare
|
Merged all commits into one, and rebased branch - to see if the Workflows fare better. |
@jukzi there has been no more inputs on this PR in the meantime, do you think it would be possible to land it at this point? |
3 participants
Modify the 'Close Active Editors' (plural) handler to add support for parts which represent an Editor and have been contributed via eg. PartDescriptors in a Model Fragment.
See also, the recent and similar PR: #2315
Associated with Issue#2176.
@mickaelistria - just tagging you here since you were good enough to review the other related PR recently (2315).